Bug 157404 - Muted media elements should be allowed to autoplay, even if RequireUserGestureForAudioRateChange is set.
Summary: Muted media elements should be allowed to autoplay, even if RequireUserGestur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-05 18:17 PDT by Jer Noble
Modified: 2016-10-31 09:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2016-05-05 18:22 PDT, Jer Noble 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (941.89 KB, application/zip)
2016-05-05 19:11 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (1.32 MB, application/zip)
2016-05-05 19:19 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (1.37 MB, application/zip)
2016-05-05 19:25 PDT, Build Bot 		no flags Details
Patch for landing (5.63 KB, patch)
2016-05-06 09:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (5.66 KB, patch)
2016-05-06 09:27 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-05-05 18:17:06 PDT 
Muted media elements should be allowed to autoplay, even if RequireUserGestureForAudioRateChange is set.
Comment 1 Jer Noble 2016-05-05 18:19:51 PDT 
<rdar://problem/26016802>
Comment 2 Jer Noble 2016-05-05 18:22:08 PDT 
Created attachment 278214 [details]
Patch
Comment 3 Eric Carlson 2016-05-05 18:41:07 PDT 
Comment on attachment 278214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278214&action=review

> LayoutTests/media/audio-playback-restriction-play-muted.html:23
> +        run('video.play().then(playing).catch(failTest)');

I think you can rewrite this to use the 'playing' event if you don't want to wait for https://bugs.webkit.org/show_bug.cgi?id=157400.
Comment 4 Build Bot 2016-05-05 19:11:30 PDT 
Comment on attachment 278214 [details]
Patch

Attachment 278214 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1274294

New failing tests:
media/audio-playback-restriction-play-muted.html
Comment 5 Build Bot 2016-05-05 19:11:33 PDT 
Created attachment 278218 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-05 19:19:15 PDT 
Comment on attachment 278214 [details]
Patch

Attachment 278214 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1274348

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-05-05 19:19:18 PDT 
Created attachment 278219 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-05-05 19:25:39 PDT 
Comment on attachment 278214 [details]
Patch

Attachment 278214 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1274313

New failing tests:
media/audio-playback-restriction-play-muted.html
Comment 9 Build Bot 2016-05-05 19:25:41 PDT 
Created attachment 278220 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Jer Noble 2016-05-06 09:25:26 PDT 
Created attachment 278251 [details]
Patch for landing
Comment 11 Jer Noble 2016-05-06 09:27:22 PDT 
Created attachment 278252 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2016-05-06 12:53:33 PDT 
Comment on attachment 278252 [details]
Patch for landing

Clearing flags on attachment: 278252

Committed r200516: <http://trac.webkit.org/changeset/200516>