Bug 157400 – Return a Promise from HTMLMediaElement.play()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Return a Promise from HTMLMediaElement.play()

[Jer Noble]

Created attachment 278204 [details]
Patch

[Build Bot]

Comment on attachment 278204 [details]
Patch

Attachment 278204 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1273998

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
media/media-load-event.html

[Build Bot]

Created attachment 278209 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278204 [details]
Patch

Attachment 278204 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1274002

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
media/media-load-event.html

[Build Bot]

Created attachment 278210 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278204 [details]
Patch

Attachment 278204 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1274010

New failing tests:
media/media-load-event.html

[Build Bot]

Created attachment 278211 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Comment on attachment 278204 [details]
Patch

r=me - once the tests all pass :-)

[Jer Noble]

Created attachment 278271 [details]
Patch

[Jer Noble]

Created attachment 278274 [details]
Patch

[Eric Carlson]

Comment on attachment 278274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278274&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:914
> +    pendingPlayPromises.swap(m_pendingPlayPromises);

Wouldn't move be better than swap here?

> Source/WebCore/html/HTMLMediaElement.cpp:923
> +    pendingPlayPromises.swap(m_pendingPlayPromises);

Ditto.

[Jer Noble]

Created attachment 278299 [details]
Patch for landing

[Build Bot]

Comment on attachment 278299 [details]
Patch for landing

Attachment 278299 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1279381

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html

[Build Bot]

Created attachment 278303 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278299 [details]
Patch for landing

Attachment 278299 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1279387

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html

[Build Bot]

Created attachment 278304 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278299 [details]
Patch for landing

Attachment 278299 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1279510

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html

[Build Bot]

Created attachment 278310 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 278327 [details]
Patch for landing

[Build Bot]

Comment on attachment 278327 [details]
Patch for landing

Attachment 278327 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1283174

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html

[Build Bot]

Created attachment 278332 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 278441 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 278441 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/GenericTaskQueue.h:56:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 278441 [details]
Patch for landing

Attachment 278441 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1295081

New failing tests:
editing/selection/move-by-word-visually-crash-test-4.html

[Build Bot]

Created attachment 278443 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278441 [details]
Patch for landing

Attachment 278441 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1295107

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 278446 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278441 [details]
Patch for landing

Attachment 278441 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1295266

New failing tests:
editing/selection/move-by-word-visually-crash-test-4.html

[Build Bot]

Created attachment 278452 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Jer Noble]

Created attachment 278500 [details]
Patch for landing

[Build Bot]

Comment on attachment 278500 [details]
Patch for landing

Attachment 278500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1299301

New failing tests:
editing/selection/move-by-word-visually-crash-test-4.html

[Build Bot]

Created attachment 278506 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278500 [details]
Patch for landing

Attachment 278500 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1299302

New failing tests:
editing/selection/move-by-word-visually-crash-test-4.html

[Build Bot]

Created attachment 278507 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278500 [details]
Patch for landing

Attachment 278500 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1299300

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 278509 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278500 [details]
Patch for landing

Attachment 278500 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1299306

New failing tests:
editing/selection/move-by-word-visually-crash-test-4.html

[Build Bot]

Created attachment 278510 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Jer Noble]

Committed r200627: <http://trac.webkit.org/changeset/200627>

[Simon Fraser (smfr)]

This seems to have caused a crash in an unrelated test:
https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Debug%20WK2%20(Tests)/r200627%20(1780)/results.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 157531

[Jer Noble]

Committed r200638: <http://trac.webkit.org/changeset/200638>

[Jer Noble]

*** Bug 157530 has been marked as a duplicate of this bug. ***