Bug 156978 – Drop [UsePointersEvenForNonNullableObjectArguments] from Node

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Drop [UsePointersEvenForNonNullableObjectArguments] from Node

[youenn fablet]

Created attachment 277251 [details]
Patch

[youenn fablet]

(In reply to comment #1)
> Created attachment 277251 [details]
> Patch

The patch is not trying to change insertBefore, replaceChild, removeChild and appendChild as the DOM methods are used in various places, including GObject bindings.

[youenn fablet]

Created attachment 277368 [details]
Patch

[Build Bot]

Comment on attachment 277368 [details]
Patch

Attachment 277368 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1223684

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/dom/interfaces.html

[Build Bot]

Created attachment 277371 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277368 [details]
Patch

Attachment 277368 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1223683

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/dom/interfaces.html

[Build Bot]

Created attachment 277372 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277368 [details]
Patch

Attachment 277368 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1223688

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/dom/interfaces.html

[Build Bot]

Created attachment 277373 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[youenn fablet]

Created attachment 277462 [details]
Fixing compareDocumentPosition

[Chris Dumez]

Comment on attachment 277462 [details]
Fixing compareDocumentPosition

View in context: https://bugs.webkit.org/attachment.cgi?id=277462&action=review

r=me

> Source/WebCore/dom/Node.idl:67
> +    [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node? newChild,

Since those are Custom, why do we need the change?

> Source/WebCore/dom/Node.idl:70
> +    [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node replaceChild(Node? newChild,

Since those are Custom, why do we need the change?

> Source/WebCore/dom/Node.idl:73
> +    [Custom, RaisesException] Node removeChild([CustomReturn] Node? oldChild);

Since those are Custom, why do we need the change?

> Source/WebCore/dom/Node.idl:75
> +    [Custom, RaisesException] Node appendChild([CustomReturn] Node? newChild);

Since those are Custom, why do we need the change?

[youenn fablet]

Thanks for the review.

> > Source/WebCore/dom/Node.idl:75
> > +    [Custom, RaisesException] Node appendChild([CustomReturn] Node? newChild);
> 
> Since those are Custom, why do we need the change?

It is breaking GObject and probably ObjC binding code.

[WebKit Commit Bot]

Comment on attachment 277462 [details]
Fixing compareDocumentPosition

Clearing flags on attachment: 277462

Committed r200197: <http://trac.webkit.org/changeset/200197>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.