Bug 156583 – Make <a download> a runtime enabled option

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The <a download> feature isn't very useful without Blob download support, so we don't want to ship this with production builds of WebKit. However, since we want to encourage experimentation with the feature, we should switch from a compile-time flag to a runtime option.

[Radar WebKit Bug Importer]

<rdar://problem/25733449>

[Brent Fulgham]

Created attachment 276416 [details]
Patch

[Alex Christensen]

Comment on attachment 276416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276416&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:560
> +    if (RuntimeEnabledFeatures::sharedFeatures().downloadAttributeEnabled())
> +        downloadAttribute = fastGetAttribute(downloadAttr);

Is this the only place we need to check if it's enabled before doing something?

[Build Bot]

Comment on attachment 276416 [details]
Patch

Attachment 276416 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1157956

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
js/dom/dom-static-property-for-in-iteration.html
imported/w3c/web-platform-tests/html/dom/reflection-text.html

[Build Bot]

Created attachment 276427 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276416 [details]
Patch

Attachment 276416 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1158039

New failing tests:
js/dom/dom-static-property-for-in-iteration.html

[Build Bot]

Created attachment 276433 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Brent Fulgham]

To enable the feature after this patch, do the following (on Mac) to test with Safari.

defaults write com.apple.Safari com.apple.Safari.ContentPageGroupIdentifier.WebKit2DownloadAttributeEnabled -bool yes

[Brent Fulgham]

I identified the cause of the WK1 test failures and fixed them locally prior to landing. I am able to run WK1 and WK2 tests without errors.

[Brent Fulgham]

Committed r199571: <http://trac.webkit.org/changeset/199571>