Bug 156291 – [IDL] Extend support for [EnabledAtRuntime] attributes / operations to all global objects, not just Window

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Extend support for [EnabledAtRuntime] attributes / operations to all global objects, not just Window.

[Chris Dumez]

Created attachment 275775 [details]
Patch

[WebKit Commit Bot]

Attachment 275775 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:164:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:180:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:215:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:233:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:341:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/scripts/test/ObjC/DOMTestGlobalObject.mm:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Diff on generated JSWorkerGlobalScope.cpp:
http://pastebin.com/4esG76hq

[Alex Christensen]

Comment on attachment 275775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275775&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:381
> +    return $interface->name eq "DOMWindow" || $codeGenerator->InheritsInterface($interface, "WorkerGlobalScope") || $interface->name eq "TestGlobalObject";

Great! I was thinking last night, "there's no test for this".  Now I can sleep better.

[Chris Dumez]

(In reply to comment #4)
> Comment on attachment 275775 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=275775&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:381
> > +    return $interface->name eq "DOMWindow" || $codeGenerator->InheritsInterface($interface, "WorkerGlobalScope") || $interface->name eq "TestGlobalObject";
> 
> Great! I was thinking last night, "there's no test for this".  Now I can
> sleep better.

Yeah, I was tired last night :P

[Chris Dumez]

Comment on attachment 275775 [details]
Patch

Clearing flags on attachment: 275775

Committed r199103: <http://trac.webkit.org/changeset/199103>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.