Bug 156272 - Add support for [EnabledAtRuntime] operations on DOMWindow
Summary: Add support for [EnabledAtRuntime] operations on DOMWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 156113
  Show dependency tree / graph
 
Reported: 2016-04-05 18:48 PDT by Chris Dumez
Modified: 2016-04-06 09:25 PDT (History)
10 users (show)

See Also:

Attachments
WIP Patch for ews (3.39 KB, patch)
2016-04-05 21:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch for ews (4.21 KB, patch)
2016-04-05 21:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.53 KB, patch)
2016-04-05 21:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-05 18:48:13 PDT 
Add support for [EnabledAtRuntime] operation on DOMWindow. We currently support this only for non-Window object.
Once this is supported, we can get rid of the hack introduced in:
<http://trac.webkit.org/changeset/199081>
Comment 1 Chris Dumez 2016-04-05 21:02:02 PDT 
Created attachment 275742 [details]
WIP Patch for ews
Comment 2 Chris Dumez 2016-04-05 21:03:41 PDT 
Created attachment 275743 [details]
WIP Patch for ews
Comment 3 Chris Dumez 2016-04-05 21:57:16 PDT 
Created attachment 275752 [details]
Patch
Comment 4 Chris Dumez 2016-04-05 21:59:52 PDT 
This generates the following in JSDOMWindow::finishCreation():
#if ENABLE(FETCH_API)
    if (RuntimeEnabledFeatures::sharedFeatures().fetchAPIEnabled())
        putDirectNativeFunction(vm, this, vm.propertyNames->fetch, 1, jsDOMWindowInstanceFunctionFetch, NoIntrinsic, attributesForStructure(JSC::Function));
#endif
Comment 5 WebKit Commit Bot 2016-04-05 23:10:35 PDT 
Comment on attachment 275752 [details]
Patch

Clearing flags on attachment: 275752

Committed r199096: <http://trac.webkit.org/changeset/199096>
Comment 6 WebKit Commit Bot 2016-04-05 23:10:42 PDT 
All reviewed patches have been landed.  Closing bug.