Bug 156091 - CookieJar should support adding synthetic cookies for developer tools
Summary: CookieJar should support adding synthetic cookies for developer tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 156296 156298 156345 31157 156090 156295 156319
  Show dependency tree / graph
 
Reported: 2016-03-31 16:33 PDT by BJ Burg
Modified: 2020-03-29 03:08 PDT (History)
21 users (show)

See Also:

Attachments
Proposed Fix (24.57 KB, patch)
2016-04-06 13:53 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (26.22 KB, patch)
2016-04-06 16:38 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (26.69 KB, patch)
2016-04-07 09:54 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-03-31 16:33:13 PDT 
.
Comment 1 BJ Burg 2016-03-31 16:34:36 PDT 
This is needed to interactively edit cookies through Web Inspector, or add cookies to an ephemeral testing context (that would otherwise have no cookies).
Comment 2 BJ Burg 2016-04-01 17:07:50 PDT 
Moving parts:

1. New CookieJar method.
2. New platform method(s) in PlatformCookieJar.
3. New WebCookieManager[Proxy] methods and messages.
4. Hook up inspector / automation to the new method!
Comment 3 Radar WebKit Bug Importer 2016-04-06 11:38:01 PDT 
<rdar://problem/25581340>
Comment 4 BJ Burg 2016-04-06 13:53:36 PDT 
Created attachment 275816 [details]
Proposed Fix
Comment 5 Alex Christensen 2016-04-06 14:02:30 PDT 
Comment on attachment 275816 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275816&action=review

> Source/WebCore/platform/network/mac/CookieJarMac.mm:269
> +#if !USE(CFNETWORK)

This whole file is inside of !USE(CFNETWORK).  This is not needed.
Comment 6 BJ Burg 2016-04-06 14:04:53 PDT 
Comment on attachment 275816 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275816&action=review

>> Source/WebCore/platform/network/mac/CookieJarMac.mm:269
>> +#if !USE(CFNETWORK)
> 
> This whole file is inside of !USE(CFNETWORK).  This is not needed.

Well, most of it. Oops.
Comment 7 BJ Burg 2016-04-06 16:38:13 PDT 
Created attachment 275829 [details]
For EWS
Comment 8 BJ Burg 2016-04-07 09:54:13 PDT 
Created attachment 275892 [details]
For EWS
Comment 9 BJ Burg 2016-04-07 11:09:34 PDT 
Writing a test will be in a followup. It will use TestWebKitAPI and a new C SPI for WKCookie object and WKCookieManager method. See https://bugs.webkit.org/show_bug.cgi?id=156345.
Comment 10 WebKit Commit Bot 2016-04-07 12:00:54 PDT 
Comment on attachment 275892 [details]
For EWS

Clearing flags on attachment: 275892

Committed r199167: <http://trac.webkit.org/changeset/199167>
Comment 11 WebKit Commit Bot 2016-04-07 12:01:01 PDT 
All reviewed patches have been landed.  Closing bug.