Bug 155834 - Web Inspector: Timeline range selection changes with ProfileView should not cause navigation bar items to flicker
Summary: Web Inspector: Timeline range selection changes with ProfileView should not c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-23 22:22 PDT by Joseph Pecoraro
Modified: 2016-03-23 23:32 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.25 KB, patch)
2016-03-23 22:23 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-23 22:22:21 PDT
* SUMMARY
Timeline range selection changes with ProfileView should not cause navigation bar items to flicker.

* STEPS TO REPRODUCE
1. Open Inspector
2. Show Timeline tab
3. Enable Scripts & Events timeline
4. Start recording a timeline with JS
5. Stop recording
6. Select Script & Events timeline
7. Make lots of Timeline Range selections in Overview
  => Navigation bar buttons flicker
Comment 1 Radar WebKit Bug Importer 2016-03-23 22:22:56 PDT
<rdar://problem/25332282>
Comment 2 Joseph Pecoraro 2016-03-23 22:23:23 PDT
Created attachment 274819 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2016-03-23 22:41:31 PDT
Comment on attachment 274819 [details]
[PATCH] Proposed Fix

This is good, but we should not flicker even if the event is over zealous. Sounds a lot like bug 149258.
Comment 4 WebKit Commit Bot 2016-03-23 23:32:29 PDT
Comment on attachment 274819 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274819

Committed r198618: <http://trac.webkit.org/changeset/198618>
Comment 5 WebKit Commit Bot 2016-03-23 23:32:33 PDT
All reviewed patches have been landed.  Closing bug.