Created attachment 261388 [details] [Animated GIF] Bug Steps: 1. Open http://www.apple.com 2. Inspect <body> 3. In the right sidebar, select "Styles — Rules" 4. Type "color" inside the Styles Attribute section Actual: DOM path bar blinks on every key stroke. Expected: DOM path bar shouldn't blink.
<rdar://problem/22737843>
This might be a regression caused by switching to requestAnimationFrame for updateLayoutSoon.
Heh, I was just going to file this bug, but my video clip got buried somewhere.
(In reply to comment #2) > This might be a regression caused by switching to requestAnimationFrame for > updateLayoutSoon. Good call! I caused this regression in http://trac.webkit.org/changeset/188494. The flashing as the navigation bar updates is also visible when selecting nodes in the DOM tree content view. Working on a fix.
Created attachment 264159 [details] [Patch] Proposed Fix
Comment on attachment 264159 [details] [Patch] Proposed Fix Clearing flags on attachment: 264159 Committed r191640: <http://trac.webkit.org/changeset/191640>
All reviewed patches have been landed. Closing bug.
The problem still persists on r194173. (Should I reopen bugs for cases like this?)
Created attachment 278447 [details] WIP This fixed the issue when the the DOM path bar isn't very long, e.g. the nesting isn't very deep. I'm not sure what difference does it make. I'm continuing looking.
Created attachment 278448 [details] WIP
Created attachment 278459 [details] Patch
Comment on attachment 278459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278459&action=review > Source/WebInspectorUI/ChangeLog:10 > + (value): Should fix the name here.
Comment on attachment 278459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278459&action=review >> Source/WebInspectorUI/ChangeLog:10 >> + (value): > > Should fix the name here. Should fix the name here. > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js:77 > + _componentsEqual(a, b) > + { > + let getRepresentedObjects = (component) => component.representedObject; > + > + let representedObjectsA = a.map(getRepresentedObjects); > + let representedObjectsB = b.map(getRepresentedObjects); > + return Array.shallowEqual(representedObjectsA, representedObjectsB); > + } This method has a underscore, but it is in the Public section. It should move to the Private section or, since it is only used once, inlined next to the caller above.
With the last patch the icons on the right are still blinking. I need to combine my two latest patches into one.
Created attachment 278463 [details] Patch Not setting r+ since there are more changes.
Comment on attachment 278463 [details] Patch Clearing flags on attachment: 278463 Committed r200605: <http://trac.webkit.org/changeset/200605>