Bug 155829 - [ES6] Greedy unicode RegExp's don't properly backtrack past non BMP characters
Summary: [ES6] Greedy unicode RegExp's don't properly backtrack past non BMP characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks: 155807
  Show dependency treegraph
 
Reported: 2016-03-23 21:22 PDT by Michael Saboff
Modified: 2016-03-24 07:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.25 KB, patch)
2016-03-23 22:15 PDT, Michael Saboff
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-03-23 21:22:20 PDT
I found this while working on <https://bugs.webkit.org/show_bug.cgi?id=155807>
Comment 1 Michael Saboff 2016-03-23 22:15:17 PDT
Created attachment 274817 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-03-23 22:15:44 PDT
<rdar://problem/25332220>
Comment 3 Saam Barati 2016-03-23 22:32:20 PDT
Comment on attachment 274817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274817&action=review

> Source/JavaScriptCore/runtime/RegExpObject.cpp:194
> +        size_t stringLength = s.length();

Nit: length is unsigned not size_t
Comment 4 Michael Saboff 2016-03-24 07:19:37 PDT
Committed r198624: <http://trac.webkit.org/changeset/198624>