Bug 155807 – [ES6] Add Proxy based tests for RegExp.prototype[@@match]

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

In <https://bugs.webkit.org/show_bug.cgi?id=155711> after change set r198554 was landed, it was suggested that we add more Proxy based tests to verify standards conformance.  This would include handling the semantics issue raise in this comment:

> > Source/JavaScriptCore/builtins/RegExpPrototype.js:59
> > +    if (regexp.exec !== @RegExp.prototype.@exec && typeof(regexp.exec) === "function") {
> Also, I'm not sure this is correct. You're calling "get" twice here. That is
> an observable
> operation. It looks like RegExpExec only does this get once in the spec.

[Radar WebKit Bug Importer]

<rdar://problem/25331854>

[Michael Saboff]

Created attachment 274831 [details]
Patch

[WebKit Commit Bot]

Attachment 274831 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tests/stress/regexp-match-proxy.js:102:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-match-proxy.js:137:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 274832 [details]
Updated Patch - Removed Tabs

[Saam Barati]

Comment on attachment 274832 [details]
Updated Patch - Removed Tabs

r=me
Does es6.yaml also need to be updated?

[Michael Saboff]

(In reply to comment #5)
> Comment on attachment 274832 [details]
> Updated Patch - Removed Tabs
> 
> r=me
> Does es6.yaml also need to be updated?

Yes it does, so I'll do it before landing.

[Michael Saboff]

Committed r198625: <http://trac.webkit.org/changeset/198625>