Bug 155657 – JSDOMGlobalObject.h needs to #include StructureInlines.h

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

The Win EWS is complaining about the following:

WebCore.lib(EmptyClients.obj) : error LNK2019: unresolved external symbol "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPAV12@AAVVM@2@PAVJSGlobalObject@2@VJSValue@2@ABVTypeInfo@2@PBUClassInfo@2@EI@Z) referenced in function "public: static class JSC::Structure * __cdecl WebCore::JSDOMGlobalObject::createStructure(class JSC::VM &,class JSC::JSValue)" (?createStructure@JSDOMGlobalObject@WebCore@@SAPAVStructure@JSC@@AAVVM@4@VJSValue@4@@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]
C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals 

Structure::create() is implemented in StructureInlines.h.  Just need to #include the header file.

[Mark Lam]

Created attachment 274444 [details]
proposed patch.

[Mark Lam]

Let's try it on the EWS first.

[Filip Pizlo]

Comment on attachment 274444 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=274444&action=review

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:33
> +#include <runtime/StructureInlines.h>

Any reason not to include JSCInlines.h?

[Mark Lam]

(In reply to comment #3)
> Comment on attachment 274444 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274444&action=review
> 
> > Source/WebCore/bindings/js/JSDOMGlobalObject.h:33
> > +#include <runtime/StructureInlines.h>
> 
> Any reason not to include JSCInlines.h?

I was only targeting the specific issue that was reported by the EWS.  JSCInlines.h should work but is overkill for now.

[Mark Lam]

Thanks.  Landed in r198440: <http://trac.webkit.org/r198440>.