Bug 155567 - AX: Implement AutoFill Available attribute for a text field
Summary: AX: Implement AutoFill Available attribute for a text field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
: 145200 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-03-16 16:47 PDT by chris fleizach
Modified: 2016-08-19 15:09 PDT (History)
3 users (show)

See Also:


Attachments
patch (12.94 KB, patch)
2016-03-16 16:49 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (13.56 KB, patch)
2016-03-16 17:02 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (14.15 KB, patch)
2016-03-16 17:30 PDT, chris fleizach
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2016-03-16 16:47:03 PDT
Make sure auto fill buttons are accessible and that we notify the text field that its available too

<rdar://problem/24307473>
Comment 1 chris fleizach 2016-03-16 16:49:53 PDT
Created attachment 274235 [details]
patch
Comment 2 chris fleizach 2016-03-16 17:02:00 PDT
Created attachment 274239 [details]
patch
Comment 3 chris fleizach 2016-03-16 17:30:03 PDT
Created attachment 274245 [details]
patch
Comment 4 Darin Adler 2016-03-17 09:25:32 PDT
Comment on attachment 274245 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274245&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2207
> +    if (!node || !is<HTMLInputElement>(*node))
> +        return false;

This can be written like this:

    if (!is<HTMLInputElement>(node))
        return false;

The is<> function does the null check as long as you pass it a pointer rather than a reference.
Comment 5 chris fleizach 2016-03-17 09:29:24 PDT
(In reply to comment #4)
> Comment on attachment 274245 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274245&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2207
> > +    if (!node || !is<HTMLInputElement>(*node))
> > +        return false;
> 
> This can be written like this:
> 
>     if (!is<HTMLInputElement>(node))
>         return false;
> 
> The is<> function does the null check as long as you pass it a pointer
> rather than a reference.

Thanks!
Comment 6 chris fleizach 2016-03-17 09:39:37 PDT
http://trac.webkit.org/changeset/198333
Comment 7 Daniel Bates 2016-08-19 15:09:34 PDT
*** Bug 145200 has been marked as a duplicate of this bug. ***