Bug 155567 – AX: Implement AutoFill Available attribute for a text field

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Make sure auto fill buttons are accessible and that we notify the text field that its available too

<rdar://problem/24307473>

[chris fleizach]

Created attachment 274235 [details]
patch

[chris fleizach]

Created attachment 274239 [details]
patch

[chris fleizach]

Created attachment 274245 [details]
patch

[Darin Adler]

Comment on attachment 274245 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274245&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2207
> +    if (!node || !is<HTMLInputElement>(*node))
> +        return false;

This can be written like this:

    if (!is<HTMLInputElement>(node))
        return false;

The is<> function does the null check as long as you pass it a pointer rather than a reference.

[chris fleizach]

(In reply to comment #4)
> Comment on attachment 274245 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274245&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2207
> > +    if (!node || !is<HTMLInputElement>(*node))
> > +        return false;
> 
> This can be written like this:
> 
>     if (!is<HTMLInputElement>(node))
>         return false;
> 
> The is<> function does the null check as long as you pass it a pointer
> rather than a reference.

Thanks!

[chris fleizach]

http://trac.webkit.org/changeset/198333

[Daniel Bates]

*** Bug 145200 has been marked as a duplicate of this bug. ***