AX: AutoFill button is not accessible with VoiceOver

[Daniel Bates]

We should make the AutoFill button accessible to people that use VoiceOver just as we do for other buttons, including the search field cancel button.

[Daniel Bates]

<rdar://problem/20507480>

[Radar WebKit Bug Importer]

<rdar://problem/21032401>

[Radar WebKit Bug Importer]

<rdar://problem/21032404>

[Daniel Bates]

(In reply to comment #2)
> <rdar://problem/21032401>

(In reply to comment #3)
> <rdar://problem/21032404>

Disregard these radars.

[Daniel Bates]

Created attachment 253426 [details]
Patch

[Daniel Bates]

I took inspiration from class AccessibilitySearchFieldCancelButton.

[chris fleizach]

Comment on attachment 253426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253426&action=review

thanks! looking good

> Source/WebCore/accessibility/AccessibilityAutoFillButton.cpp:55
> +    textOrder.append(AccessibilityText(accessibilityDescription(), AlternativeText));

It might be easier to set the label in the code that creates the object

    m_autoFillButton->setAttribute(aria_labelAttr, "autofill");

then the existing text calculation methods can take over, since this is a AXRenderObject

> Source/WebCore/accessibility/AccessibilityAutoFillButton.cpp:60
> +    return accessibilityIsIgnoredByDefault();

this override might not be necessary. maybe you tested this and it was because something the AXRenderObject method return YES to ignore, but there's a chance that this would just work by default

> Source/WebCore/accessibility/AccessibilityAutoFillButton.h:39
> +    AccessibilityRole roleValue() const override { return ButtonRole; }

these three methods can be private

[Daniel Bates]

Created attachment 253444 [details]
Patch

Updated patched based on Chris Fleizach's feedback.

[Daniel Bates]

Committed r184645: <http://trac.webkit.org/changeset/184645>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 145220

[Jake Nielsen]

As Alexey noticed, this broke the build.

[Alexey Proskuryakov]

Dan, looks like you fixed the reason why EWS was red, but the landed patch broke the build in a different way: <https://webkit-queues.appspot.com/results/4565750211674112>.

Additionally, the new test fails on Windows: https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r184646%20(51955)/accessibility/input-auto-fill-button-diff.txt

[Daniel Bates]

Committed r184660: <http://trac.webkit.org/changeset/184660>

[Daniel Bates]

Rolled out <http://trac.webkit.org/changeset/184660> in <http://trac.webkit.org/changeset/186012> because it caused a regression.

[Daniel Bates]

Re-opening bug.

[Daniel Bates]

*** This bug has been marked as a duplicate of bug 155567 ***