Bug 155535 - WebRTC: Update RTCIceCandidate
Summary: WebRTC: Update RTCIceCandidate
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 143211
  Show dependency treegraph
Reported: 2016-03-16 00:34 PDT by Adam Bergkvist
Modified: 2016-03-17 03:57 PDT (History)
3 users (show)

See Also:

Proposed patch (21.12 KB, patch)
2016-03-16 00:57 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff
Proposed patch (21.12 KB, patch)
2016-03-16 02:54 PDT, Adam Bergkvist
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (21.12 KB, patch)
2016-03-17 01:52 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-03-16 00:34:07 PDT
Updates needed to better match the WebRTC 1.0 specification [1]
- "candidate" init dictionary member is required at construction
- At lest one of the "sdpMid" and "sdpMLineIndex" dictionary members must be present at construction
- sdpMid and sdpMLineIndex attributes are nullable 

[1] https://w3c.github.io/webrtc-pc/archives/20160215/webrtc.html
Comment 1 Adam Bergkvist 2016-03-16 00:57:04 PDT
Created attachment 274183 [details]
Proposed patch
Comment 2 Adam Bergkvist 2016-03-16 02:54:26 PDT
Created attachment 274185 [details]
Proposed patch

With mac build fix (unused param)
Comment 3 Eric Carlson 2016-03-16 11:59:29 PDT
Comment on attachment 274185 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274185&action=review

> Source/WebCore/ChangeLog:9
> +        In short: The "candidate" init dictionary member is required. At least one of dictionary

Nit: At least one of *the* ...

> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:61
> +        if (!intConversionOk || result > 65535) {

Nit: you can use USHRT_MAX here.
Comment 4 Adam Bergkvist 2016-03-17 01:52:40 PDT
Created attachment 274271 [details]
Patch for landing
Comment 5 Adam Bergkvist 2016-03-17 02:15:53 PDT
Thanks for your review Eric. Both comments addressed in patch for landing.
Comment 6 WebKit Commit Bot 2016-03-17 03:52:06 PDT
Comment on attachment 274271 [details]
Patch for landing

Clearing flags on attachment: 274271

Committed r198325: <http://trac.webkit.org/changeset/198325>