We've a TODO in GridResolvedPosition class: // TODO(rego): Rename class to GridPositionsResolver. This was already done in Blink: https://codereview.chromium.org/1648903002/
Created attachment 274082 [details] Patch
Comment on attachment 274082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274082&action=review r=me provided all the EWS are happy with the rename > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2 > + * Copyright (C) 2014 Igalia S.L. Let's use this to update the copyright to 2014, 2016 > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38 > +#include <cstdlib> Are we really using this include? > Source/WebCore/rendering/style/GridPositionsResolver.h:2 > + * Copyright (C) 2014 Igalia S.L. Ditto.
Created attachment 274084 [details] Patch
Thanks for the review (In reply to comment #2) > > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2 > > + * Copyright (C) 2014 Igalia S.L. > > Let's use this to update the copyright to 2014, 2016 Done. > > > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38 > > +#include <cstdlib> > > Are we really using this include? We need it for std::abs(int). > > Source/WebCore/rendering/style/GridPositionsResolver.h:2 > > + * Copyright (C) 2014 Igalia S.L. > > Ditto. Done.
Comment on attachment 274084 [details] Patch Clearing flags on attachment: 274084 Committed r198207: <http://trac.webkit.org/changeset/198207>
All reviewed patches have been landed. Closing bug.