Bug 155486 - [css-grid] Rename GridResolvedPosition to GridPositionsResolver
Summary: [css-grid] Rename GridResolvedPosition to GridPositionsResolver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 153488
  Show dependency treegraph
 
Reported: 2016-03-15 01:36 PDT by Manuel Rego Casasnovas
Modified: 2016-03-15 03:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (58.41 KB, patch)
2016-03-15 01:37 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (58.43 KB, patch)
2016-03-15 02:49 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-03-15 01:36:27 PDT
We've a TODO in GridResolvedPosition class:
// TODO(rego): Rename class to GridPositionsResolver.

This was already done in Blink:
https://codereview.chromium.org/1648903002/
Comment 1 Manuel Rego Casasnovas 2016-03-15 01:37:59 PDT
Created attachment 274082 [details]
Patch
Comment 2 Sergio Villar Senin 2016-03-15 01:47:02 PDT
Comment on attachment 274082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274082&action=review

r=me provided all the EWS are happy with the rename

> Source/WebCore/rendering/style/GridPositionsResolver.cpp:2
> + * Copyright (C) 2014 Igalia S.L.

Let's use this to update the copyright to 2014, 2016

> Source/WebCore/rendering/style/GridPositionsResolver.cpp:38
> +#include <cstdlib>

Are we really using this include?

> Source/WebCore/rendering/style/GridPositionsResolver.h:2
> + * Copyright (C) 2014 Igalia S.L.

Ditto.
Comment 3 Manuel Rego Casasnovas 2016-03-15 02:49:24 PDT
Created attachment 274084 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2016-03-15 02:50:34 PDT
Thanks for the review

(In reply to comment #2)
> > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2
> > + * Copyright (C) 2014 Igalia S.L.
> 
> Let's use this to update the copyright to 2014, 2016

Done.

> 
> > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38
> > +#include <cstdlib>
> 
> Are we really using this include?

We need it for std::abs(int).

> > Source/WebCore/rendering/style/GridPositionsResolver.h:2
> > + * Copyright (C) 2014 Igalia S.L.
> 
> Ditto.

Done.
Comment 5 WebKit Commit Bot 2016-03-15 03:38:30 PDT
Comment on attachment 274084 [details]
Patch

Clearing flags on attachment: 274084

Committed r198207: <http://trac.webkit.org/changeset/198207>
Comment 6 WebKit Commit Bot 2016-03-15 03:38:35 PDT
All reviewed patches have been landed.  Closing bug.