Placement for undefined named lines is not working as described in the spec:
Mainly we're not following this statement from the spec:
"If a name is given as a <custom-ident>, only lines with that name are counted. If not enough lines with that name exist, all lines in the implicit grid are assumed to have that name for the purpose of finding this position."
Bug has been already fixed in Blink:
We need to port:
Created attachment 273430 [details]
Comment on attachment 273430 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=273430&action=review
> + return end + numberOfLines - 1;
I think we can do this in a single line.
> + return start - numberOfLines + 1;
> + NamedGridLinesMap::const_iterator it = gridLinesNames.find(position.namedGridLine());
We can use auto for these two.
Created attachment 273556 [details]
Thanks for the review, uploaded new patch for landing applying suggested changes.
Comment on attachment 273556 [details]
Clearing flags on attachment: 273556
Committed r197930: <http://trac.webkit.org/changeset/197930>
All reviewed patches have been landed. Closing bug.