Bug 155065 - Add parsing support for object-position
Summary: Add parsing support for object-position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 122811
  Show dependency tree / graph
 
Reported: 2016-03-05 12:04 PST by Simon Fraser (smfr)
Modified: 2016-03-05 15:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (31.27 KB, patch)
2016-03-05 12:13 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (31.37 KB, patch)
2016-03-05 12:27 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
Patch (31.58 KB, patch)
2016-03-05 12:44 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (31.40 KB, patch)
2016-03-05 13:13 PST, Simon Fraser (smfr) 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-03-05 12:04:09 PST 
First stage of supporting object-position: parsing.
Comment 1 Simon Fraser (smfr) 2016-03-05 12:13:40 PST 
Created attachment 273090 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-05 12:27:05 PST 
Created attachment 273092 [details]
Patch
Comment 3 Sam Weinig 2016-03-05 12:33:45 PST 
Comment on attachment 273092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273092&action=review

> Source/WebCore/css/CSSParser.cpp:2891
> +        RefPtr<CSSPrimitiveValue> val1;
> +        RefPtr<CSSPrimitiveValue> val2;

Can we use the whole word here? value1 and value2?

> Source/WebCore/css/StyleBuilderConverter.h:319
> +    Length length;

Please move this to below where it is initialize.
Comment 4 Simon Fraser (smfr) 2016-03-05 12:44:03 PST 
Created attachment 273093 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-03-05 13:13:38 PST 
Created attachment 273094 [details]
Patch
Comment 6 Simon Fraser (smfr) 2016-03-05 15:25:31 PST 
https://trac.webkit.org/r197617