WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155065
Add parsing support for object-position
https://bugs.webkit.org/show_bug.cgi?id=155065
Summary
Add parsing support for object-position
Simon Fraser (smfr)
Reported
2016-03-05 12:04:09 PST
First stage of supporting object-position: parsing.
Attachments
Patch
(31.27 KB, patch)
2016-03-05 12:13 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(31.37 KB, patch)
2016-03-05 12:27 PST
,
Simon Fraser (smfr)
sam
: review+
Details
Formatted Diff
Diff
Patch
(31.58 KB, patch)
2016-03-05 12:44 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(31.40 KB, patch)
2016-03-05 13:13 PST
,
Simon Fraser (smfr)
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-03-05 12:13:40 PST
Created
attachment 273090
[details]
Patch
Simon Fraser (smfr)
Comment 2
2016-03-05 12:27:05 PST
Created
attachment 273092
[details]
Patch
Sam Weinig
Comment 3
2016-03-05 12:33:45 PST
Comment on
attachment 273092
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=273092&action=review
> Source/WebCore/css/CSSParser.cpp:2891 > + RefPtr<CSSPrimitiveValue> val1; > + RefPtr<CSSPrimitiveValue> val2;
Can we use the whole word here? value1 and value2?
> Source/WebCore/css/StyleBuilderConverter.h:319 > + Length length;
Please move this to below where it is initialize.
Simon Fraser (smfr)
Comment 4
2016-03-05 12:44:03 PST
Created
attachment 273093
[details]
Patch
Simon Fraser (smfr)
Comment 5
2016-03-05 13:13:38 PST
Created
attachment 273094
[details]
Patch
Simon Fraser (smfr)
Comment 6
2016-03-05 15:25:31 PST
https://trac.webkit.org/r197617
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug