Bug 154965 – [TextureMapper] Use RGBA format for textures attached to framebuffers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Miguel Gomez]

BitmapTextureGL internal textures always use BGRA format when the GL_EXT_texture_format_BGRA8888 extension is available, which is good for uploading data to them. But if those textures are not used to upload data, but to be attached to framebuffers, using BGRA can be a problem in some platforms (for example the RPi, where currently a BGRA texture can't be attached to a framebuffer). So, in general, using RGBA for attachment textures would be more standard and platform-friendly.

[Miguel Gomez]

Created attachment 272751 [details]
Patch

[WebKit Commit Bot]

Attachment 272751 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:79:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:91:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 272751 [details]
Patch

Clearing flags on attachment: 272751

Committed r197506: <http://trac.webkit.org/changeset/197506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

There might be a small typo in line 95 in BitmapTexturePool.cpp.
Should we be getting the size of m_attachmentTextures instead of m_textures?

93	        for (size_t i = 0; i < m_attachmentTextures.size(); ++i) {
94	            if (m_attachmentTextures[i].m_lastUsedTime < minUsedTime) {
95	                m_attachmentTextures.remove(i, m_textures.size() - i);
96	                break;
97	            }

[Miguel Gomez]

> There might be a small typo in line 95 in BitmapTexturePool.cpp.
> Should we be getting the size of m_attachmentTextures instead of m_textures?
> 
> 93	        for (size_t i = 0; i < m_attachmentTextures.size(); ++i) {
> 94	            if (m_attachmentTextures[i].m_lastUsedTime < minUsedTime) {
> 95	                m_attachmentTextures.remove(i, m_textures.size() - i);
> 96	                break;
> 97	            }

You're totally right! I've created a follow up in https://bugs.webkit.org/show_bug.cgi?id=155105 and I'll send a fix in a while.