Bug 154911 - [css-grid] Simplify method to resolve auto-placed items
Summary: [css-grid] Simplify method to resolve auto-placed items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 153488
  Show dependency treegraph
 
Reported: 2016-03-02 00:20 PST by Manuel Rego Casasnovas
Modified: 2016-03-03 02:23 PST (History)
8 users (show)

See Also:


Attachments
Patch (11.99 KB, patch)
2016-03-02 00:21 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (11.96 KB, patch)
2016-03-02 01:03 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-03-02 00:20:14 PST
Port this patch from Blink: https://codereview.chromium.org/1496863004/
Comment 1 Manuel Rego Casasnovas 2016-03-02 00:21:27 PST
Created attachment 272641 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-03-02 01:03:44 PST
Created attachment 272644 [details]
Patch
Comment 3 Sergio Villar Senin 2016-03-03 01:12:04 PST
Comment on attachment 272644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272644&action=review

> Source/WebCore/rendering/style/GridResolvedPosition.cpp:242
> +    return position.spanPosition();

We should change the name of this method at some point because it isn't clear that it's returning the span (spanPosition looks like a type of position).
Comment 4 WebKit Commit Bot 2016-03-03 02:23:28 PST
Comment on attachment 272644 [details]
Patch

Clearing flags on attachment: 272644

Committed r197501: <http://trac.webkit.org/changeset/197501>
Comment 5 WebKit Commit Bot 2016-03-03 02:23:31 PST
All reviewed patches have been landed.  Closing bug.