Now --ftl-jit is passed to run-jsc-stress-tests on these bots (by run-javascriptcore-tests): - Apple El Capitan 32-bit JSC (BuildAndTest) - Apple Yosemite 32-bit JSC (BuildAndTest) There is no reason to run 30k tests instead of 17k since there is no FTL JIT on 32 bit architectures.
Created attachment 272563 [details] Patch
ping
Shouldn't this behavior be baked in run-javascriptcore-tests? This combination is never useful, not just on the bots.
Comment on attachment 272563 [details] Patch Clearing flags on attachment: 272563 Committed r197442: <http://trac.webkit.org/changeset/197442>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > Shouldn't this behavior be baked in run-javascriptcore-tests? This > combination is never useful, not just on the bots. It would be better ... but I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm to determine if we build Apple Mac x86 JSC. But I'll be happy to review any patch replaces this with a better fix in run-javascriptcore-tests.
It seems automatical buildbot master restart still doesn't work. :( Could you possibly restart the master manually?
> It seems automatical buildbot master restart still doesn't work. :( It's not supposed to, as it's a fairly dangerous operation, so it's better if someone with direct access to the server is around to perform it.
> I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm I do not know how to best do that, but I'm sure that someone on the CC list does.
(In reply to comment #8) > > It seems automatical buildbot master restart still doesn't work. :( > > It's not supposed to, as it's a fairly dangerous operation, so it's better > if someone with direct access to the server is around to perform it. Previously it worked properly. Nowadays all webkitpy and BuildSlaveSupport change triggers restart except master.cfg and config.json. (bug107052) I think it can be dangerous only if folks land master.cfg changes blindly without local testing or at least unit testing. But in this case an immediate rollout would fix the master without direct access to the server.
(In reply to comment #9) > > I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm > > I do not know how to best do that, but I'm sure that someone on the CC list > does. I don't think there is any current way to know if FTL is enabled. One solution would be to have the jsc binary have some option that prints information about the build e.g. if FTL/DFG are enabled. Then run-javascriptcore-tests could just not run the modes relevant to those builds. I'm not sure that's a high priority to implement but maybe it's something we should consider in the future. A quicker, less general fix would be to have run-javascriptcore-tests run the file command on the jsc binary and not run FTL tests if the binary is 32-bit.
Ping for master restart.
(In reply to comment #12) > Ping for master restart. Done that.
Re-opened since this is blocked by bug 154967
I won't have time for it, feel free to pick it up if you are interested in 80 mins runtime instead of 110 mins on 32 bit bots.
Rolled out in r197442, so the master needs to be restarted again.
Close as resolved/wontfix, because it won't be possible after https://trac.webkit.org/changeset/203440.