Bug 107052 - Buildmaster shouldn't restart after all webkitpy change
Summary: Buildmaster shouldn't restart after all webkitpy change
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-16 14:49 PST by Csaba Osztrogonác
Modified: 2015-09-24 07:32 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-01-16 14:49:16 PST
It seems build.webkit.org restarts itself after all webkitpy change.
Today it was restarted twice in a short period because of these changes:
- http://build.webkit.org/changes/20528 (http://trac.webkit.org/changeset/139913)
- http://build.webkit.org/changes/20539 (http://trac.webkit.org/changeset/139924)

Do we really need restarting master after all webkitpy change?
I think only master.cfg changes should trigger master restart.
Comment 1 Lucas Forschler 2015-09-24 07:29:30 PDT
Buildbot is restarted via post commit hook from the svn sever. The post commit hook reads as follows:

#
# update build.webkit.org
#
UPDATE_BUILDBOT=$(/usr/bin/svnlook changed $REPOS -r $REV | /bin/grep -cE '(webkitpy|BuildSlaveSupport)')
if [ $UPDATE_BUILDBOT -gt 0 ];
then
	/usr/bin/ssh -t buildbot@build.webkit.org "/usr/bin/sudo -n /usr/local/bin/buildbot-update-restart --force" >> /tmp/post-commit.log 2>&1 &
fi
Comment 2 Lucas Forschler 2015-09-24 07:32:04 PDT
However, looking in the buildbot-update-restart code, it seems we filter out on config.json or master.cfg changes

RESTART=$(/usr/bin/svn log -r $OLDREV:HEAD -vq | grep -cE '(config.json|master.cfg)');