Bug 154687 - streams/pipe-to.html flaky on mac-wk1 debug
Summary: streams/pipe-to.html flaky on mac-wk1 debug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-25 12:15 PST by Ryan Haddad
Modified: 2016-12-14 15:01 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2016-02-26 00:23 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-02-25 12:15:32 PST
streams/pipe-to.html flaky on mac-wk1

Most recent failing run:
<https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK1%20(Tests)/builds/11065>

Flakiness dashboard:
<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=streams%2Fpipe-to.html>

--- /Volumes/Data/slave/yosemite-debug-tests-wk1/build/layout-test-results/streams/pipe-to-expected.txt
+++ /Volumes/Data/slave/yosemite-debug-tests-wk1/build/layout-test-results/streams/pipe-to-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Piping to a writable stream that does not consume the writes fast enough exerts backpressure on the source 
+FAIL Piping to a writable stream that does not consume the writes fast enough exerts backpressure on the source assert_equals: at t = 125 ms, ws should be waiting expected "waiting" but got "writable"
Comment 1 youenn fablet 2016-02-26 00:23:44 PST
Created attachment 272312 [details]
Patch
Comment 2 youenn fablet 2016-02-26 00:27:18 PST
(In reply to comment #0)
> streams/pipe-to.html flaky on mac-wk1

This test should probably rewritten somehow to make it less slow and subject to flakiness. Since it comes from whatwg reference tests, but not yet migrated to WPT tests, it might be better to just increase the timeout period.
If that does not work, we might flakg it as flaky for debug builds.
Comment 3 WebKit Commit Bot 2016-02-29 10:51:22 PST
Comment on attachment 272312 [details]
Patch

Clearing flags on attachment: 272312

Committed r197359: <http://trac.webkit.org/changeset/197359>
Comment 4 WebKit Commit Bot 2016-02-29 10:51:25 PST
All reviewed patches have been landed.  Closing bug.