Bug 154686 - Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB
Summary: Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on: 157072
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2016-02-25 11:56 PST by Brady Eidson
Modified: 2016-04-28 11:47 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (9.71 KB, patch)
2016-04-27 22:47 PDT, Brady Eidson 		achristensen: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-02-25 11:56:59 PST 
Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB

Modern IDB was enabled for both WK1 and WK2 in http://trac.webkit.org/changeset/197122

The Web Inspector code that relies on Legacy IDB constructs is now dead.

It will be pruned further in https://bugs.webkit.org/show_bug.cgi?id=150854

It needs to be reimplemented for Modern IDB.
Comment 1 Radar WebKit Bug Importer 2016-02-25 11:57:12 PST 
<rdar://problem/24842865>
Comment 2 Brady Eidson 2016-04-26 15:12:48 PDT 
I'm reimplementing getDatabaseNames now.
Comment 3 Brady Eidson 2016-04-27 09:14:37 PDT 
getAllDatabaseNames is just part of this, so I spun it off into its own bug: https://bugs.webkit.org/show_bug.cgi?id=157072
Comment 4 Brady Eidson 2016-04-27 22:47:38 PDT 
Created attachment 277594 [details]
Patch v1

This patch hooks up all the previous functionality that had been removed in r197131

It gets database info, object store info, and index info, and shows them in the tables off to the side.

However, the DataLoader and ClearObjectStore functionality do not work.

The reason is that the code doesn't wait for the IDBTransaction created to actually become active.

I won't have time to re-architect this to that end.
Comment 5 Brady Eidson 2016-04-28 11:13:23 PDT 
(In reply to comment #4)
> Created attachment 277594 [details]
> 
> However, the DataLoader and ClearObjectStore functionality do not work.
> 
> The reason is that the code doesn't wait for the IDBTransaction created to
> actually become active.


This actually seems odd, as transactions are supposed to start out active.

I'll look into this outside of this patch landing.
Comment 6 Brady Eidson 2016-04-28 11:45:17 PDT 
As EWS shows, this patch was good when uploaded.
http://trac.webkit.org/changeset/200192 broke it.

I'll update to match then land manually.
Comment 7 Brady Eidson 2016-04-28 11:47:07 PDT 
http://trac.webkit.org/changeset/200202