Bug 154686 – Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brady Eidson]

Modern IDB: Reimplement Web Inspector code that was tied to Legacy IDB

Modern IDB was enabled for both WK1 and WK2 in http://trac.webkit.org/changeset/197122

The Web Inspector code that relies on Legacy IDB constructs is now dead.

It will be pruned further in https://bugs.webkit.org/show_bug.cgi?id=150854

It needs to be reimplemented for Modern IDB.

[Radar WebKit Bug Importer]

<rdar://problem/24842865>

[Brady Eidson]

I'm reimplementing getDatabaseNames now.

[Brady Eidson]

getAllDatabaseNames is just part of this, so I spun it off into its own bug: https://bugs.webkit.org/show_bug.cgi?id=157072

[Brady Eidson]

Created attachment 277594 [details]
Patch v1

This patch hooks up all the previous functionality that had been removed in r197131

It gets database info, object store info, and index info, and shows them in the tables off to the side.

However, the DataLoader and ClearObjectStore functionality do not work.

The reason is that the code doesn't wait for the IDBTransaction created to actually become active.

I won't have time to re-architect this to that end.

[Brady Eidson]

(In reply to comment #4)
> Created attachment 277594 [details]
> 
> However, the DataLoader and ClearObjectStore functionality do not work.
> 
> The reason is that the code doesn't wait for the IDBTransaction created to
> actually become active.


This actually seems odd, as transactions are supposed to start out active.

I'll look into this outside of this patch landing.

[Brady Eidson]

As EWS shows, this patch was good when uploaded.
http://trac.webkit.org/changeset/200192 broke it.

I'll update to match then land manually.

[Brady Eidson]

http://trac.webkit.org/changeset/200202