Bug 154518 – Connect WebAutomationSession to its backend dispatcher as if it were an agent and add stub implementations

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Woo.

[Radar WebKit Bug Importer]

<rdar://problem/24761096>

[Blaze Burg]

Created attachment 271885 [details]
Proposed Fix

[Blaze Burg]

Created attachment 271899 [details]
For Landing

[WebKit Commit Bot]

Attachment 271899 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:102:  out_windows is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:112:  in_handle is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 271901 [details]
Fix GTK

[WebKit Commit Bot]

Attachment 271901 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:102:  out_windows is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:112:  in_handle is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 272017 [details]
For EWS

[WebKit Commit Bot]

Attachment 272017 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:102:  out_windows is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:112:  in_handle is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 272017 [details]
For EWS

Clearing flags on attachment: 272017

Committed r196980: <http://trac.webkit.org/changeset/196980>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #9)
> Comment on attachment 272017 [details]
> For EWS
> 
> Clearing flags on attachment: 272017
> 
> Committed r196980: <http://trac.webkit.org/changeset/196980>

It broke the Apple Mac cmake build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/2725

cc-ing the build system maintainer

[Csaba Osztrogonác]

(In reply to comment #11)
> (In reply to comment #9)
> > Comment on attachment 272017 [details]
> > For EWS
> > 
> > Clearing flags on attachment: 272017
> > 
> > Committed r196980: <http://trac.webkit.org/changeset/196980>
> 
> It broke the Apple Mac cmake build:
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/2725
> 
> cc-ing the build system maintainer

The build is still broken ... but maybe bug154509 did some wrong thing too ...

[Csaba Osztrogonác]

build log:

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/Cocoa/AutomationSessionClient.mm:31:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:54:25: error: unknown class name 'AutomationBackendDispatcherHandler'; did you mean 'RuntimeBackendDispatcherHandler'?
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/Cocoa/_WKAutomationSession.mm:27:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/Cocoa/_WKAutomationSessionInternal.h:31:
    , public Inspector::AutomationBackendDispatcherHandler
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        RuntimeBackendDispatcherHandler/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:54:25: error: unknown class name 'AutomationBackendDispatcherHandler'; did you mean 'RuntimeBackendDispatcherHandler'?

    , public Inspector::AutomationBackendDispatcherHandler
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        RuntimeBackendDispatcherHandler

[Csaba Osztrogonác]

Ping

[Blaze Burg]

(In reply to comment #13)
> build log:
> 
> In file included from
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/
> Cocoa/AutomationSessionClient.mm:31:
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/
> Automation/WebAutomationSession.h:54:25: error: unknown class name
> 'AutomationBackendDispatcherHandler'; did you mean
> 'RuntimeBackendDispatcherHandler'?
> In file included from
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/
> Cocoa/_WKAutomationSession.mm:27:
> In file included from
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/
> Cocoa/_WKAutomationSessionInternal.h:31:
>     , public Inspector::AutomationBackendDispatcherHandler
>                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                        
> RuntimeBackendDispatcherHandler/Volumes/Data/slave/elcapitan-cmake-debug/
> build/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:54:25:
> error: unknown class name 'AutomationBackendDispatcherHandler'; did you mean
> 'RuntimeBackendDispatcherHandler'?
> 
>     , public Inspector::AutomationBackendDispatcherHandler
>                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                         RuntimeBackendDispatcherHandler

I don't have an easy way to test fixes for this bot since there's no EWS. The maintainer will have to address it, or wait until I have access to such a machine.

[Csaba Osztrogonác]

(In reply to comment #15)
> I don't have an easy way to test fixes for this bot since there's no EWS.
> The maintainer will have to address it, or wait until I have access to such
> a machine.

Why not? AFAIK you only need to pass --cmake to build-webkit on a Mac.

[Csaba Osztrogonác]

The build is still broken because of this change. The question 
is if Apple maintains its own cmake build system or not. It seems no ...

[Csaba Osztrogonác]

7 days later and the build is still broken ...

[Timothy Hatcher]

(In reply to comment #18)
> 7 days later and the build is still broken ...

You could try to fix it as well instead of relentlessly commenting. We don't have time to look at it currently. From webkit-dev, "the CMake build on Mac is experimental and incomplete right now".

[Csaba Osztrogonác]

(In reply to comment #19)
> (In reply to comment #18)
> > 7 days later and the build is still broken ...
> 
> You could try to fix it as well instead of relentlessly commenting. We don't
> have time to look at it currently. From webkit-dev, "the CMake build on Mac
> is experimental and incomplete right now".

I fixed many build issue (after Apple employees) blindly, but it's
impossible to fix this one without a Mac. An EWS could help, but
there isn't.

Does experimental mean here that everyone can break it and 
nobody is responsible to fix the build within a reasonable time?
If yes, I will simply ignore this bot and won't report new issues.

[Blaze Burg]

(In reply to comment #20)

> Does experimental mean here that everyone can break it and 
> nobody is responsible to fix the build within a reasonable time?
> If yes, I will simply ignore this bot and won't report new issues.

Yes, that's what it means. It's a side project, just like WinCairo. Sometimes people don't have time to keep it maintained, sometimes they do. Which is why we can't roll out patches simply because they break CMake- it doesn't even have EWS.

[Csaba Osztrogonác]

The original patch landed a month ago, and the build is still broken:

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/WebProcessPool.cpp:46:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:56:25: error: unknown class name 'AutomationBackendDispatcherHandler'; did you mean 'RuntimeBackendDispatcherHandler'?
    , public Inspector::AutomationBackendDispatcherHandler
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        RuntimeBackendDispatcherHandler
/Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/JavaScriptCore/inspector/InspectorBackendDispatchers.h:341:25: note: 'RuntimeBackendDispatcherHandler' declared here
class JS_EXPORT_PRIVATE RuntimeBackendDispatcherHandler {
                        ^

[Timothy Hatcher]

Again, we don't have time to look at it currently.