Yup.
<rdar://problem/24759098>
Created attachment 271877 [details] Proposed Fix
Comment on attachment 271877 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271877&action=review > Source/WebKit2/UIProcess/Automation/Automation.json:33 > + "description": "Closes the specified window." Copy paste error: Opens a window.
Comment on attachment 271877 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271877&action=review >> Source/WebKit2/UIProcess/Automation/Automation.json:33 >> + "description": "Closes the specified window." > > Copy paste error: Opens a window. I see you fixed this in the patch for bug 154518.
(In reply to comment #4) > Comment on attachment 271877 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271877&action=review > > >> Source/WebKit2/UIProcess/Automation/Automation.json:33 > >> + "description": "Closes the specified window." > > > > Copy paste error: Opens a window. > > I see you fixed this in the patch for bug 154518. I'll move the changes to this patch before landing.
Created attachment 271890 [details] Test the CMake waters
Attachment 271890 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:230: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:231: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:165: [generate_from_specification] Undefined variable 'CppBackendDispatcherHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:166: [generate_from_specification] Undefined variable 'CppBackendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:167: [generate_from_specification] Undefined variable 'CppProtocolTypesHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:168: [generate_from_specification] Undefined variable 'CppProtocolTypesImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:172: [generate_from_specification] Undefined variable 'ObjCConversionHelpersGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:173: [generate_from_specification] Undefined variable 'ObjCFrontendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:174: [generate_from_specification] Undefined variable 'ObjCProtocolTypesImplementationGenerator' [pylint/E0602] [5] Total errors found: 9 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 271891 [details] CMake try #2
Attachment 271891 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:230: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:231: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:165: [generate_from_specification] Undefined variable 'CppBackendDispatcherHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:166: [generate_from_specification] Undefined variable 'CppBackendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:167: [generate_from_specification] Undefined variable 'CppProtocolTypesHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:168: [generate_from_specification] Undefined variable 'CppProtocolTypesImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:172: [generate_from_specification] Undefined variable 'ObjCConversionHelpersGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:173: [generate_from_specification] Undefined variable 'ObjCFrontendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:174: [generate_from_specification] Undefined variable 'ObjCProtocolTypesImplementationGenerator' [pylint/E0602] [5] Total errors found: 9 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r196891: <http://trac.webkit.org/changeset/196891>
Comment on attachment 271891 [details] CMake try #2 View in context: https://bugs.webkit.org/attachment.cgi?id=271891&action=review > Source/WebKit2/DerivedSources.make:214 > +JSON_RPC_OUTPUT_FILES = \ JSON_RPC seems vague. So is outputting files named InspectorBackendDispatcher. Could we s/Inspector/Automation/ eventually? > Source/WebKit2/UIProcess/Automation/Automation.json:26 > + "description": "Gets information about all open windows and tabs in the automation session." Perhaps we could take this opportunity to put the "description" next to the "name" in the new JSON files? This order always bugged me! > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:31 > +#include <JavaScriptCore/InspectorBackendDispatcher.h> > +#include <JavaScriptCore/InspectorFrontendRouter.h> Hmm, I had thought this was an issue with other ports in the past. But maybe they don't build these files, in which case it seems fine to use this <JavaScriptCore/...> syntax.
(In reply to comment #11) > Comment on attachment 271891 [details] > CMake try #2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271891&action=review > > > Source/WebKit2/DerivedSources.make:214 > > +JSON_RPC_OUTPUT_FILES = \ > > JSON_RPC seems vague. So is outputting files named > InspectorBackendDispatcher. Could we s/Inspector/Automation/ eventually? Wasn't sure of a better prefix than JSON_RPC. Maybe add 'Protocol' in for good measure. At least it doesn't say Inspector. I plan to change the Inspector* filename prefix in the future for generated protocol files. Just wanted to get it working for now. > > Source/WebKit2/UIProcess/Automation/Automation.json:26 > > + "description": "Gets information about all open windows and tabs in the automation session." > > Perhaps we could take this opportunity to put the "description" next to the > "name" in the new JSON files? This order always bugged me! OK > > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:31 > > +#include <JavaScriptCore/InspectorBackendDispatcher.h> > > +#include <JavaScriptCore/InspectorFrontendRouter.h> > > Hmm, I had thought this was an issue with other ports in the past. But maybe > they don't build these files, in which case it seems fine to use this > <JavaScriptCore/...> syntax. These includes will pull from ForwardingHeaders or headers installed to ${BUILT_PRODUCTS_DIR}/usr/lib/include. Every port does this, far as I know.
Re-opened since this is blocked by bug 154539
Created attachment 271948 [details] Take 2
Created attachment 271980 [details] For EWS, Landing
Attachment 271980 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:230: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:231: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:165: [generate_from_specification] Undefined variable 'CppBackendDispatcherHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:166: [generate_from_specification] Undefined variable 'CppBackendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:167: [generate_from_specification] Undefined variable 'CppProtocolTypesHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:168: [generate_from_specification] Undefined variable 'CppProtocolTypesImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:172: [generate_from_specification] Undefined variable 'ObjCConversionHelpersGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:173: [generate_from_specification] Undefined variable 'ObjCFrontendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:174: [generate_from_specification] Undefined variable 'ObjCProtocolTypesImplementationGenerator' [pylint/E0602] [5] Total errors found: 9 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 271989 [details] For Landing
Attachment 271989 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:230: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:231: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:165: [generate_from_specification] Undefined variable 'CppBackendDispatcherHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:166: [generate_from_specification] Undefined variable 'CppBackendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:167: [generate_from_specification] Undefined variable 'CppProtocolTypesHeaderGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:168: [generate_from_specification] Undefined variable 'CppProtocolTypesImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:172: [generate_from_specification] Undefined variable 'ObjCConversionHelpersGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:173: [generate_from_specification] Undefined variable 'ObjCFrontendDispatcherImplementationGenerator' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:174: [generate_from_specification] Undefined variable 'ObjCProtocolTypesImplementationGenerator' [pylint/E0602] [5] Total errors found: 9 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 271989 [details] For Landing Clearing flags on attachment: 271989 Committed r196970: <http://trac.webkit.org/changeset/196970>
All reviewed patches have been landed. Closing bug.
(In reply to comment #19) > Comment on attachment 271989 [details] > For Landing > > Clearing flags on attachment: 271989 > > Committed r196970: <http://trac.webkit.org/changeset/196970> It made fast/profiler tests crash on EFL/GTK buildbots and made them exit early after 50+ crashes. See build.webkit.org for details. cc-ing port maintainers
This patch broke the inspector in GTK+ and EFL ports and caused a lot of crashes in both ports bots.
(In reply to comment #21) > (In reply to comment #19) > > Comment on attachment 271989 [details] > > For Landing > > > > Clearing flags on attachment: 271989 > > > > Committed r196970: <http://trac.webkit.org/changeset/196970> > > It made fast/profiler tests crash on EFL/GTK buildbots and made > them exit early after 50+ crashes. See build.webkit.org for details. > > cc-ing port maintainers This patch didn't touch anything related to the profiler, nor do these failures show on Mac/Win. So this is very surprising. There have been recent profiler changes, however.
(In reply to comment #22) > This patch broke the inspector in GTK+ and EFL ports and caused a lot of > crashes in both ports bots. You'll need to provide more information (hang? crash? nothing shows?) otherwise I can't really do anything about it.
(In reply to comment #24) > (In reply to comment #22) > > This patch broke the inspector in GTK+ and EFL ports and caused a lot of > > crashes in both ports bots. > > You'll need to provide more information (hang? crash? nothing shows?) > otherwise I can't really do anything about it. Yes, I didn't have time yesterday to debug the issue. The inspector made the web process crash, and I just confirmed that reverting r196970 fixed the issue. Now looking at the GTK+ bots it seems that r196980 fixed the crashes.
(In reply to comment #25) > (In reply to comment #24) > > (In reply to comment #22) > > > This patch broke the inspector in GTK+ and EFL ports and caused a lot of > > > crashes in both ports bots. > > > > You'll need to provide more information (hang? crash? nothing shows?) > > otherwise I can't really do anything about it. > > Yes, I didn't have time yesterday to debug the issue. The inspector made the > web process crash, and I just confirmed that reverting r196970 fixed the > issue. Now looking at the GTK+ bots it seems that r196980 fixed the crashes. r196980 fixed the issue in the release build, but it also caused the debug build to assert on all fast/profiler tests with this: fast/profiler/anonymous-function-called-from-different-contexts.html crashed, (stderr lines): ASSERTION FAILED: result == "EventDispatch" || result == "ScheduleStyleRecalculation" || result == "RecalculateStyles" || result == "InvalidateLayout" || result == "Layout" || result == "Paint" || result == "Composite" || result == "RenderingFrame" || result == "TimerInstall" || result == "TimerRemove" || result == "TimerFire" || result == "EvaluateScript" || result == "TimeStamp" || result == "Time" || result == "TimeEnd" || result == "FunctionCall" || result == "ProbeSample" || result == "ConsoleProfile" || result == "RequestAnimationFrame" || result == "CancelAnimationFrame" || result == "FireAnimationFrame" DerivedSources/JavaScriptCore/inspector/InspectorProtocolObjects.cpp(872) : static void Inspector::Protocol::BindingTraits<Inspector::Protocol::Timeline::EventType>::assertValueHasExpectedType(Inspector::InspectorValue*) 1 0x7fac2dbd77ef /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7fac2dbd77ef] 2 0x7fac2dbd3719 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN9Inspector8Protocol13BindingTraitsINS0_8Timeline9EventTypeEE26assertValueHasExpectedTypeEPNS_14InspectorValueE+0x331) [0x7fac2dbd3719] 3 0x7fac2dbd38fd /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN9Inspector8Protocol13BindingTraitsINS0_8Timeline13TimelineEventEE26assertValueHasExpectedTypeEPNS_14InspectorValueE+0x1b5) [0x7fac2dbd38fd] 4 0x7fac2dbd3c67 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN9Inspector8Protocol13BindingTraitsINS0_8Timeline13TimelineEventEE11runtimeCastEON3WTF6RefPtrINS_14InspectorValueEEE+0x85) [0x7fac2dbd3c67] 5 0x7fac34dfc77c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore22InspectorTimelineAgent19addRecordToTimelineEON3WTF6RefPtrIN9Inspector15InspectorObjectEEENS_18TimelineRecordTypeE+0x108) [0x7fac34dfc77c] 6 0x7fac34dfcbcc /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore22InspectorTimelineAgent22didCompleteRecordEntryERKNS0_19TimelineRecordEntryE+0x1d0) [0x7fac34dfcbcc] 7 0x7fac34dfb44c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore22InspectorTimelineAgent15stopFromConsoleEPN3JSC9ExecStateERKN3WTF6StringE+0x18c) [0x7fac34dfb44c] 8 0x7fac34da9309 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore24InspectorInstrumentation17stopProfilingImplERNS_19InstrumentingAgentsEPN3JSC9ExecStateERKN3WTF6StringE+0x47) [0x7fac34da9309] 9 0x7fac34fc405b /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore24InspectorInstrumentation13stopProfilingERNS_4PageEPN3JSC9ExecStateERKN3WTF6StringE+0x3b) [0x7fac34fc405b] 10 0x7fac34fc3bc5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore17PageConsoleClient10profileEndEPN3JSC9ExecStateERKN3WTF6StringE+0x31) [0x7fac34fc3bc5] 11 0x7fac2d9719ec /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1d589ec) [0x7fac2d9719ec] 12 0x7fabdd7fe0c8 [0x7fabdd7fe0c8] 0033/39138] fast/profiler/anonymous-function-called-from-different-contexts.html failed unexpectedly (WebProcess crashed)
Created attachment 272322 [details] Simple test producing crashes on GTK+ Debug There are two lines in this test which, when any of the two is removed, make the test not crash.
A follow up bug would be more appropriate to track the assert you are seeing.