Bug 154373 - [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
Summary: [SVG] Update SVG source to return string literals as ASCIILiteral and add tes...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Andronikos
Depends on:
Reported: 2016-02-17 18:35 PST by Nikos Andronikos
Modified: 2016-02-23 08:30 PST (History)
2 users (show)

See Also:

Patch (51.28 KB, patch)
2016-02-17 18:44 PST, Nikos Andronikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Andronikos 2016-02-17 18:35:37 PST
This patch updates the SVGAnimatedEnumerations toString method to return ASCIILiteral for string literals (as identified in bug 141376, comment 13).
The patch also adds test cases for case-sensitivity as required by SVG (as requested in bug 138456, comment 26).
Comment 1 Nikos Andronikos 2016-02-17 18:44:35 PST
Created attachment 271612 [details]
Comment 2 youenn fablet 2016-02-23 07:45:04 PST
Comment on attachment 271612 [details]

Looks good to me.

Two side notes:
1. It might have been slightly better to split this patch in two parts (going to ASCIILiteral and adding the new case insensitive tests) since they seem to be independent.
2 Regarding the tests, testharness.js would have been a good fit here, especially since the tests are sync
It might have made the test expectation a bit easier to read and the test file a bit simpler (no need for debug("") e.g.).
The test could also be contributed to W3C test suite.
Comment 3 WebKit Commit Bot 2016-02-23 08:30:46 PST
Comment on attachment 271612 [details]

Clearing flags on attachment: 271612

Committed r196977: <http://trac.webkit.org/changeset/196977>
Comment 4 WebKit Commit Bot 2016-02-23 08:30:51 PST
All reviewed patches have been landed.  Closing bug.