Spec: http://www.w3.org/TR/filter-effects-1/#valdef-operator-lighter Support has been added to Blink: https://code.google.com/p/chromium/issues/detail?id=439037
You can take a look at http://trac.webkit.org/changeset/170433 to see how new compositing modes (that are not part of SVGOM) can be implemented.
Created attachment 267534 [details] Patch
Attachment 267534 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/filters/FEComposite.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/filters/FEComposite.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 267534 [details] did not pass style-queue: Note: style failures are false positives in this case. SVG code uses all caps for enums everywhere.
Comment on attachment 267534 [details] Patch Attachment 267534 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/570037 New failing tests: svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
Created attachment 267540 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 267534 [details] Patch Attachment 267534 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/570034 New failing tests: svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
Created attachment 267541 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 267534 [details] Patch Attachment 267534 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/570020 New failing tests: svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
Created attachment 267542 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 270087 [details] Patch
Attachment 270087 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/filters/FEComposite.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/filters/FEComposite.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 270087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270087&action=review > Source/WebCore/svg/SVGFECompositeElement.h:56 > + return "lighter"; All the values in this function should be returning ASCIILiteral("lighter") instead.
Comment on attachment 270087 [details] Patch Clearing flags on attachment: 270087 Committed r195745: <http://trac.webkit.org/changeset/195745>
All reviewed patches have been landed. Closing bug.
(In reply to comment #13) > Comment on attachment 270087 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270087&action=review > > > Source/WebCore/svg/SVGFECompositeElement.h:56 > > + return "lighter"; > > All the values in this function should be returning ASCIILiteral("lighter") > instead. Darin, what's the process for making this change now that the patch has landed? Or is this just something to keep in mind for next time? Thanks for reviewing btw.
Comment on attachment 270087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270087&action=review >>> Source/WebCore/svg/SVGFECompositeElement.h:56 >>> + return "lighter"; >> >> All the values in this function should be returning ASCIILiteral("lighter") instead. > > Darin, what's the process for making this change now that the patch has landed? Or is this just something to keep in mind for next time? > Thanks for reviewing btw. You can file a new webkit bug and mention that it is a follow up for this bug. Or you can reopen this bug and attach a new patch and get it reviewed and landed as the current patch.