Patch coming.
<rdar://problem/24663313>
Created attachment 271375 [details] Proposed Fix
Comment on attachment 271375 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271375&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > - [listing setObject:target.name() forKey:WIRTitleKey]; > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; Shouldn't there be a title? I'd expect something like: [listing setObject:target.name() forKey:WIRTitleKey]; [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" Style: line up
(In reply to comment #3) > Comment on attachment 271375 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271375&action=review > > > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > > - [listing setObject:target.name() forKey:WIRTitleKey]; > > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; > > Shouldn't there be a title? I'd expect something like: > > [listing setObject:target.name() forKey:WIRTitleKey]; > [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; sessionIdentifier() is part of WebAutomationSession's interface, not RemoteAutomationTarget. I'm not sure that there is a meaningful user-facing title for an automation session. > > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" > > Style: line up
Committed r196667: <http://trac.webkit.org/changeset/196667>