Bug 154012 – WKAutomationDelegate's requestAutomationSession should take a suggested session identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Patch coming.

[Radar WebKit Bug Importer]

<rdar://problem/24557697>

[Blaze Burg]

Created attachment 270889 [details]
Proposed Fix

[Darin Adler]

Comment on attachment 270889 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270889&action=review

> Source/WebKit2/UIProcess/API/APIAutomationClient.h:42
> +    virtual void didRequestAutomationSession(WebKit::WebProcessPool*, const WTF::String&) { }

Should be able to just say "const String&" without the namespace.

> Source/WebKit2/UIProcess/Cocoa/AutomationClient.h:53
> +    virtual void didRequestAutomationSession(WebKit::WebProcessPool*, const String& sessionIdentifier) override
> +    {
> +        requestAutomationSession(sessionIdentifier);
> +    }

Please put this function body in the .mm file, not the header. Keeps the class definition easier to read when the bodies are bigger than a single line.

[Blaze Burg]

(In reply to comment #3)
> Comment on attachment 270889 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270889&action=review
> 
> > Source/WebKit2/UIProcess/API/APIAutomationClient.h:42
> > +    virtual void didRequestAutomationSession(WebKit::WebProcessPool*, const WTF::String&) { }
> 
> Should be able to just say "const String&" without the namespace.

I thought that too, but Xcode was insistent that it was ambiguous with API::String. I didn't even know about that class!

> > Source/WebKit2/UIProcess/Cocoa/AutomationClient.h:53
> > +    virtual void didRequestAutomationSession(WebKit::WebProcessPool*, const String& sessionIdentifier) override
> > +    {
> > +        requestAutomationSession(sessionIdentifier);
> > +    }
> 
> Please put this function body in the .mm file, not the header. Keeps the
> class definition easier to read when the bodies are bigger than a single
> line.

OK

[Blaze Burg]

Created attachment 270950 [details]
For Landing

[Blaze Burg]

Committed r196562: <http://trac.webkit.org/changeset/196562>