Bug 154010 - Evals that use TDZ should be cacheable in the CodeCache
Summary: Evals that use TDZ should be cacheable in the CodeCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 154002
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-08 14:29 PST by Filip Pizlo
Modified: 2016-11-10 18:51 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-08 14:29:59 PST 
And we should have benchmarks for this.
Comment 1 Geoffrey Garen 2016-11-10 18:51:24 PST 
This was fixed and benchmarked in <https://bugs.webkit.org/show_bug.cgi?id=164357>. 

(Instead of making TDZ evals cacheable in the CodeCache, that patch made them cacheable in the EvalCodeCache. The performance result is even better since the EvalCodeCache caches machine code.)