Bug 154002 - CodeCache should give up on evals if there are variables under TDZ
Summary: CodeCache should give up on evals if there are variables under TDZ
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 154010
  Show dependency treegraph
Reported: 2016-02-08 12:35 PST by Filip Pizlo
Modified: 2016-02-08 14:35 PST (History)
6 users (show)

See Also:

the patch (2.39 KB, patch)
2016-02-08 12:43 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-08 12:35:42 PST
This is pretty sad, and it's another reason why we should not have used a separate check_tdz opcode to check TDZ of scoped variable loads.
Comment 1 Filip Pizlo 2016-02-08 12:43:14 PST
Created attachment 270875 [details]
the patch
Comment 2 Mark Lam 2016-02-08 12:46:59 PST
Comment on attachment 270875 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270875&action=review


> Source/JavaScriptCore/ChangeLog:16
> +        compilersm and caches can see the intended meaning of the bytecode more easily.

typo: compilersm ==> compilers
Comment 3 Filip Pizlo 2016-02-08 14:35:54 PST
Landed in http://trac.webkit.org/changeset/196272