Bug 153710 - [iOS] WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
Summary: [iOS] WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15Resource...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on: 137495
  Show dependency treegraph
Reported: 2016-01-30 09:25 PST by David Kilzer (:ddkilzer)
Modified: 2016-01-30 14:19 PST (History)
9 users (show)

See Also:

Patch v1 (2.90 KB, patch)
2016-01-30 09:53 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-01-30 09:25:39 PST
WebKit1 apps crash in ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1 on the main thread in iOS.

This is because ___ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1 is being run on the main thread, creating a race condition where the DiskCacheMonitor object can be deleted after the CFCachedURLResponseCallBackBlock grabs its pointer to use on the WebThread.
Comment 1 David Kilzer (:ddkilzer) 2016-01-30 09:26:01 PST
Comment 2 David Kilzer (:ddkilzer) 2016-01-30 09:53:04 PST
Created attachment 270308 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-01-30 11:23:04 PST
Comment on attachment 270308 [details]
Patch v1

Clearing flags on attachment: 270308

Committed r195900: <http://trac.webkit.org/changeset/195900>
Comment 4 WebKit Commit Bot 2016-01-30 11:23:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2016-01-30 14:19:21 PST
That's a very nice bit of detective work!