Bug 137495 - [iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
Summary: [iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBuffer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks: 153710
  Show dependency tree / graph
 
Reported: 2014-10-07 12:36 PDT by Pratik Solanki
Modified: 2016-01-30 09:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2014-10-07 12:38 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-10-07 12:36:24 PDT 
In r173782, I moved the disk cache handling code from the main thread (UI thread) to the web thread when we are using WebKit1 on iOS. The code tries to access the CFCachedURLResponseRef passed in the block on the web thread. This is problematic because the object may have been released before the block gets to run on the web thread. We need to manually retain/release the response.
Comment 1 Pratik Solanki 2014-10-07 12:37:04 PDT 
<rdar://problem/18495034>
Comment 2 Pratik Solanki 2014-10-07 12:38:36 PDT 
Created attachment 239427 [details]
Patch
Comment 3 Andreas Kling 2014-10-07 13:00:46 PDT 
Comment on attachment 239427 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-10-07 13:37:56 PDT 
Comment on attachment 239427 [details]
Patch

Clearing flags on attachment: 239427

Committed r174404: <http://trac.webkit.org/changeset/174404>
Comment 5 WebKit Commit Bot 2014-10-07 13:38:01 PDT 
All reviewed patches have been landed.  Closing bug.