Implement this spec change: https://github.com/whatwg/dom/pull/120 https://github.com/whatwg/html/issues/361 Tests: https://github.com/w3c/web-platform-tests/pull/2522
<rdar://problem/24419675>
I am in favor of this change but I think we should wait for [1] to be merged before making this change. [1] https://github.com/w3c/web-platform-tests/pull/2522
Created attachment 270346 [details] WIP Patch WIP Patch. Waiting for the web-platform-tests to be updated upstream and re-synced to our repo.
Attachment 270346 [details] did not pass style-queue: ERROR: Source/WebCore/page/DOMWindow.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 270346 [details] WIP Patch Attachment 270346 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/765178 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html
Created attachment 270347 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270346 [details] WIP Patch Attachment 270346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/765179 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html
Created attachment 270348 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 270372 [details] WIP Patch
Comment on attachment 270372 [details] WIP Patch Attachment 270372 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/766495 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html
Created attachment 270376 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270372 [details] WIP Patch Attachment 270372 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/766496 New failing tests: imported/w3c/web-platform-tests/dom/interfaces.html
Created attachment 270377 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged.
(In reply to comment #14) > FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged. (In reply to comment #14) > FYI https://github.com/w3c/web-platform-tests/pull/2522 has now been merged. Great, thanks for letting me know. I will update the patch.
Created attachment 270614 [details] Patch
Comment on attachment 270614 [details] Patch Rejecting attachment 270614 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 270614, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 2ab958f..d736222 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 196108 = 2ab958fe28f99e10dfef134913fe6f90ccc8f0e6 r196109 = d736222b61e288503672c3b786cfd27b51921165 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/780256
Created attachment 270660 [details] Patch
Comment on attachment 270660 [details] Patch Clearing flags on attachment: 270660 Committed r196123: <http://trac.webkit.org/changeset/196123>
All reviewed patches have been landed. Closing bug.