Bug 153592 - [css-grid] Store lines instead of tracks in GridResolvedPosition
Summary: [css-grid] Store lines instead of tracks in GridResolvedPosition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 153488
  Show dependency tree / graph
 
Reported: 2016-01-28 07:19 PST by Manuel Rego Casasnovas
Modified: 2016-01-29 01:22 PST (History)
4 users (show)

See Also:

Attachments
Patch (28.67 KB, patch)
2016-01-28 07:29 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-01-28 07:19:44 PST 
First step in the plan described in meta-bug #153488 would be to store grid lines indexes instead of track indexes in GridResolvedPosition.

This will mean port the following patch from Blink:
https://codereview.chromium.org/1451883002/
Comment 1 Manuel Rego Casasnovas 2016-01-28 07:29:24 PST 
Created attachment 270114 [details]
Patch
Comment 2 Sergio Villar Senin 2016-01-28 09:56:34 PST 
Comment on attachment 270114 [details]
Patch

Makes total sense
Comment 3 WebKit Commit Bot 2016-01-29 01:22:36 PST 
Comment on attachment 270114 [details]
Patch

Clearing flags on attachment: 270114

Committed r195808: <http://trac.webkit.org/changeset/195808>
Comment 4 WebKit Commit Bot 2016-01-29 01:22:39 PST 
All reviewed patches have been landed.  Closing bug.