Bug 153421 - Do not convert GlyphBufferAdvance to FloatSize
Summary: Do not convert GlyphBufferAdvance to FloatSize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-25 04:08 PST by Konstantin Tokarev
Modified: 2016-01-25 10:59 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2016-01-25 04:10 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2016-01-25 04:25 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-01-25 04:08:08 PST 
In Qt port we have GlyphBufferAdvance based on point type, not size type, however this code seems to work equally well with both point- and size-based GlyphBufferAdvance.
Comment 1 Konstantin Tokarev 2016-01-25 04:10:34 PST 
Created attachment 269740 [details]
Patch
Comment 2 Konstantin Tokarev 2016-01-25 04:25:08 PST 
Created attachment 269741 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-01-25 09:00:37 PST 
I think it's bad that these platform types propagate around masquerading as cross-platform types.
Comment 4 Konstantin Tokarev 2016-01-25 09:05:24 PST 
If you are interested in this kind of patches, could you help me with SVGGlyphToPathTranslator::extents (rendering/svg/SVGTextRunRenderingContext.cpp)?

It has similar issue: mapSize is used to convert width of GlyphBufferAdvance, which is converted to FloatSize for this purpose.
Comment 5 WebKit Commit Bot 2016-01-25 09:49:31 PST 
Comment on attachment 269741 [details]
Patch

Clearing flags on attachment: 269741

Committed r195539: <http://trac.webkit.org/changeset/195539>
Comment 6 WebKit Commit Bot 2016-01-25 09:49:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Konstantin Tokarev 2016-01-25 10:59:16 PST 
Did not come up with anything more elegant than https://bugs.webkit.org/show_bug.cgi?id=153429