Bug 153429 - Do not convert GlyphBufferAdvance to FloatSize
Summary: Do not convert GlyphBufferAdvance to FloatSize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-25 10:55 PST by Konstantin Tokarev
Modified: 2016-01-26 10:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2016-01-25 10:56 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2016-01-25 10:58 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-01-25 10:55:03 PST 
GlyphBufferAdvance is not necessaryly conversible to FloatSize. Also, this code was doing extra work by transforming height value.
Comment 1 Konstantin Tokarev 2016-01-25 10:56:42 PST 
Created attachment 269760 [details]
Patch
Comment 2 Konstantin Tokarev 2016-01-25 10:58:03 PST 
Created attachment 269761 [details]
Patch
Comment 3 WebKit Commit Bot 2016-01-26 10:37:46 PST 
Comment on attachment 269761 [details]
Patch

Clearing flags on attachment: 269761

Committed r195596: <http://trac.webkit.org/changeset/195596>
Comment 4 WebKit Commit Bot 2016-01-26 10:37:51 PST 
All reviewed patches have been landed.  Closing bug.