Bug 153312 - [B3][Win64] Compile fixes.
Summary: [B3][Win64] Compile fixes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 11:25 PST by peavo
Modified: 2016-01-21 15:46 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2016-01-21 11:31 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2016-01-21 12:55 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-01-21 11:25:00 PST
The MSVC runtime library has several overloads of sin, cos, pow, and log. We need to specify which overload we want to use.
Comment 1 peavo 2016-01-21 11:31:28 PST
Created attachment 269475 [details]
Patch
Comment 2 Alex Christensen 2016-01-21 12:07:41 PST
Comment on attachment 269475 [details]
Patch

This should be done the same way as https://bugs.webkit.org/show_bug.cgi?id=153127
Comment 3 peavo 2016-01-21 12:55:18 PST
Created attachment 269484 [details]
Patch
Comment 4 peavo 2016-01-21 12:55:59 PST
(In reply to comment #2)
> Comment on attachment 269475 [details]
> Patch
> 
> This should be done the same way as
> https://bugs.webkit.org/show_bug.cgi?id=153127

Thanks for reviewing :) Updated patch.
Comment 5 WebKit Commit Bot 2016-01-21 14:50:16 PST
The commit-queue encountered the following flaky tests while processing attachment 269484 [details]:

editing/selection/extend-selection-home-end.html bug 50944 (authors: kalman@chromium.org and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2016-01-21 14:50:18 PST
The commit-queue encountered the following flaky tests while processing attachment 269484 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2016-01-21 15:45:55 PST
Comment on attachment 269484 [details]
Patch

Clearing flags on attachment: 269484

Committed r195425: <http://trac.webkit.org/changeset/195425>
Comment 8 WebKit Commit Bot 2016-01-21 15:46:01 PST
All reviewed patches have been landed.  Closing bug.