Bug 153127 - [B3][Win64] Compile fixes.
Summary: [B3][Win64] Compile fixes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 06:39 PST by peavo
Modified: 2016-01-15 13:46 PST (History)
9 users (show)

See Also:


Attachments
Patch (5.41 KB, patch)
2016-01-15 06:44 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (5.02 KB, patch)
2016-01-15 11:46 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2016-01-15 12:05 PST, peavo
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-01-15 06:39:51 PST
MSVC have several overloads of fmod, pow, and ceil. We need to suggest to MSVC which one we want to use.
Comment 1 peavo 2016-01-15 06:44:55 PST
Created attachment 269048 [details]
Patch
Comment 2 peavo 2016-01-15 11:46:32 PST
Created attachment 269075 [details]
Patch
Comment 3 Alex Christensen 2016-01-15 11:48:20 PST
I liked the first patch better.  It would fail to compile if the function had a different signature, but the second patch would just force it to compile and crash.
Comment 4 peavo 2016-01-15 12:05:17 PST
Created attachment 269078 [details]
Patch
Comment 5 peavo 2016-01-15 12:05:45 PST
(In reply to comment #3)
> I liked the first patch better.  It would fail to compile if the function
> had a different signature, but the second patch would just force it to
> compile and crash.

Thanks, reverted :)
Comment 6 peavo 2016-01-15 13:46:18 PST
Committed r195145: <http://trac.webkit.org/changeset/195145>.