Bug 153144 – Drop obsolete HTMLDocument.width / height attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Drop obsolete HTMLDocument.width / height attributes.

Firefox and Chrome already no longer expose these.

[Chris Dumez]

Created attachment 269094 [details]
Patch

[Ryosuke Niwa]

When did they drop these attributes?  It seems a bit risky to drop these.  Do you have any idea how frequently this API is used?

[Chris Dumez]

Chrome dropped them a long time ago:
commit db4caeb7bfb774361db83c257f6a610ec81ed462
Author: [e-mail] <[e-mail]@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Tue Jun 25 05:16:56 2013 +0000

    Remove HTMLDocument.width and height properties
    
    No other rendering engine except WebKit supports these now, and they only
    support it apparently for content in WebView.
    
    Reference:
    https://developer.mozilla.org/en-US/docs/Web/API/document.height
    https://bugs.webkit.org/show_bug.cgi?id=72591
    https://bugs.webkit.org/show_bug.cgi?id=80494
    
    R=[e-mail],[e-mail]
    
    Review URL: https://chromiumcodereview.appspot.com/17585006
    
    git-svn-id: svn://svn.chromium.org/blink/trunk@152987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Firefox dropped it in Gecko 6.0.

I really don't think it is that risky. We also have time still to see if there is any breakage from this.

[Ryosuke Niwa]

Comment on attachment 269094 [details]
Patch

okay.

[WebKit Commit Bot]

Comment on attachment 269094 [details]
Patch

Clearing flags on attachment: 269094

Committed r195160: <http://trac.webkit.org/changeset/195160>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

See also: bug 72591, bug 82596.

[Ryosuke Niwa]

We should check the app discussed in https://bugs.webkit.org/show_bug.cgi?id=80494 is broken again or not.  It seems like this change was quite risky as I had initially suspected.