Bug 153144 - Drop obsolete HTMLDocument.width / height attributes
Summary: Drop obsolete HTMLDocument.width / height attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-01-15 13:23 PST by Chris Dumez
Modified: 2016-01-16 22:58 PST (History)
10 users (show)

See Also:


Attachments
Patch (7.07 KB, patch)
2016-01-15 13:26 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-01-15 13:23:32 PST
Drop obsolete HTMLDocument.width / height attributes.

Firefox and Chrome already no longer expose these.
Comment 1 Chris Dumez 2016-01-15 13:26:41 PST
Created attachment 269094 [details]
Patch
Comment 2 Ryosuke Niwa 2016-01-15 15:03:20 PST
When did they drop these attributes?  It seems a bit risky to drop these.  Do you have any idea how frequently this API is used?
Comment 3 Chris Dumez 2016-01-15 15:09:29 PST
Chrome dropped them a long time ago:
commit db4caeb7bfb774361db83c257f6a610ec81ed462
Author: esprehn@chromium.org <esprehn@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>
Date:   Tue Jun 25 05:16:56 2013 +0000

    Remove HTMLDocument.width and height properties
    
    No other rendering engine except WebKit supports these now, and they only
    support it apparently for content in WebView.
    
    Reference:
    https://developer.mozilla.org/en-US/docs/Web/API/document.height
    https://bugs.webkit.org/show_bug.cgi?id=72591
    https://bugs.webkit.org/show_bug.cgi?id=80494
    
    R=abarth@chromium.org,arv@chromium.org
    
    Review URL: https://chromiumcodereview.appspot.com/17585006
    
    git-svn-id: svn://svn.chromium.org/blink/trunk@152987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Firefox dropped it in Gecko 6.0.

I really don't think it is that risky. We also have time still to see if there is any breakage from this.
Comment 4 Ryosuke Niwa 2016-01-15 16:39:00 PST
Comment on attachment 269094 [details]
Patch

okay.
Comment 5 WebKit Commit Bot 2016-01-15 17:04:01 PST
Comment on attachment 269094 [details]
Patch

Clearing flags on attachment: 269094

Committed r195160: <http://trac.webkit.org/changeset/195160>
Comment 6 WebKit Commit Bot 2016-01-15 17:04:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2016-01-15 21:56:21 PST
See also: bug 72591, bug 82596.
Comment 8 Ryosuke Niwa 2016-01-16 22:58:10 PST
We should check the app discussed in https://bugs.webkit.org/show_bug.cgi?id=80494 is broken again or not.  It seems like this change was quite risky as I had initially suspected.