Bug 82596 - Remove document.width / document.height
Summary: Remove document.width / document.height
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 04:11 PDT by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2023-12-11 07:37 PST (History)
16 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2012-03-29 04:11:38 PDT
+++ This bug was initially created as a clone of Bug #72591 +++

Bug 72591 was regressed in bug 80494, despite the fact that the patch there didn't have review.
Comment 1 Alexey Proskuryakov 2012-03-29 09:17:05 PDT
> despite the fact that the patch there didn't have review.

This is factually incorrect, the patch had an r+.

Anyway, we can certainly discuss this again. However, we'll need a strong reason to consider removing this long-standing feature. In addition to compatibility constraints, there is evidence that developers want it - e.g. jQuery implements document.width/height for engines that don't have it.

As an aside, I'm puzzled by the influx of bugs asking us to remove things that are in latest official specs or used to be more widely implemented, while not seeing any bugs asking us to remove truly WebKit-specific extensions to DOM.
Comment 2 Ms2ger (he/him; ⌚ UTC+1/+2) 2012-03-29 10:17:44 PDT
(In reply to comment #1)
> As an aside, I'm puzzled by the influx of bugs asking us to remove things that are in latest official specs or used to be more widely implemented, while not seeing any bugs asking us to remove truly WebKit-specific extensions to DOM.

Would you accept patches for such bugs? If so, I'd be very happy to file them.
Comment 3 Alexey Proskuryakov 2012-03-29 11:04:55 PDT
Removing purely WebKit extensions is less controversial than removing things that are in current W3C specs. Each suggestion would need to be judged on its own merits, and I obviously cannot guarantee that all or any of these would result in code changes.
Comment 4 Ms2ger (he/him; ⌚ UTC+1/+2) 2012-03-29 11:07:00 PDT
Note that document.width/height aren't in any spec, btw.
Comment 5 Alexey Proskuryakov 2012-03-29 11:27:45 PDT
Correct. This has been extensively discussed in bug 72591.
Comment 6 Anne van Kesteren 2023-12-11 07:37:48 PST
Both of these return undefined for me. This must have gotten fixed at some point. (We still have Document::width() and Document::height(), but presumably those are for app compatibility as discussed in the various bugs.)