Bug 153071 - [Win] Remove workarounds for fixed bugs in fmod and pow.
Summary: [Win] Remove workarounds for fixed bugs in fmod and pow.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 152899
  Show dependency tree / graph
 
Reported: 2016-01-13 10:52 PST by peavo
Modified: 2016-01-14 00:53 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2016-01-13 10:59 PST, peavo 		no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2016-01-13 13:37 PST, peavo 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-01-13 10:52:58 PST 
WTF has workarounds for bugs in the MSVC implementation of fmod and pow. I believe these have been fixed, and we can remove the workarounds.
Comment 1 peavo 2016-01-13 10:59:20 PST 
Created attachment 268880 [details]
Patch
Comment 2 peavo 2016-01-13 11:00:48 PST 
I have only tested the following code:

    double a = NAN;
    bool isNan = isnan(a);
    double b = 0;
    double res = pow(a, b);

    double x = 3;
    double y = INFINITY;
    bool isInf = isinf(y);
    double result = fmod(x, y);
Comment 3 Brent Fulgham 2016-01-13 11:08:53 PST 
Comment on attachment 268880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268880&action=review

I like this change, but please wait to land for the win EWS to complete.

> Source/WTF/ChangeLog:11
> +        (wtf_atan2):

Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog thinks you did.
Comment 4 peavo 2016-01-13 11:22:12 PST 
(In reply to comment #3)
> Comment on attachment 268880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268880&action=review
> 
> I like this change, but please wait to land for the win EWS to complete.
> 
> > Source/WTF/ChangeLog:11
> > +        (wtf_atan2):
> 
> Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog
> thinks you did.

Thanks for reviewing :) I will wait for the win EWS before landing.
Comment 5 peavo 2016-01-13 13:37:04 PST 
Created attachment 268901 [details]
Patch
Comment 6 peavo 2016-01-13 13:38:31 PST 
(In reply to comment #5)
> Created attachment 268901 [details]
> Patch

Trying again, fixed compile error :)
Comment 7 Brent Fulgham 2016-01-13 13:40:38 PST 
Comment on attachment 268901 [details]
Patch

r=me
Comment 8 peavo 2016-01-14 00:53:12 PST 
Committed r195011: <http://trac.webkit.org/changeset/195011>.