Bug 152899 - [Win] Remove Windows XP Compatibility Requirements
Summary: [Win] Remove Windows XP Compatibility Requirements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: peavo
URL:
Keywords:
Depends on: 153071
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-08 10:30 PST by Brent Fulgham
Modified: 2016-05-03 11:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.87 KB, patch)
2016-05-03 07:50 PDT, peavo
bfulgham: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (907.67 KB, application/zip)
2016-05-03 09:27 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-01-08 10:30:01 PST
Now that we have stopped supporting Windows XP, we should audit our source code and get rid of places where we have workarounds to support Windows XP, or where we have continued to use old API for backwards compatibility reasons.
Comment 1 peavo 2016-05-03 07:50:07 PDT
Created attachment 277993 [details]
Patch
Comment 2 Brent Fulgham 2016-05-03 08:47:31 PDT
Comment on attachment 277993 [details]
Patch

Excellent! r=me.
Comment 3 Build Bot 2016-05-03 09:27:25 PDT
Comment on attachment 277993 [details]
Patch

Attachment 277993 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1261445

New failing tests:
imported/blink/paint/frames/iframe-with-mask.html
Comment 4 Build Bot 2016-05-03 09:27:28 PDT
Created attachment 278005 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Brent Fulgham 2016-05-03 09:34:05 PDT
(In reply to comment #4)
> Created attachment 278005 [details]
> Archive of layout-test-results from ews103 for mac-yosemite
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-ews.
> Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

This error is spurious. There is no way that changing Windows-specific code could affect the mac test output.
Comment 6 peavo 2016-05-03 11:06:59 PDT
(In reply to comment #2)
> Comment on attachment 277993 [details]
> Patch
> 
> Excellent! r=me.

Thanks! :)
Comment 7 peavo 2016-05-03 11:24:57 PDT
Committed r200382: <http://trac.webkit.org/changeset/200382>