Bug 153005 - Add a build flag for custom element
Summary: Add a build flag for custom element
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 150225
  Show dependency treegraph
Reported: 2016-01-11 21:32 PST by Ryosuke Niwa
Modified: 2016-01-12 21:48 PST (History)
5 users (show)

See Also:

Adds a build flag (36.29 KB, patch)
2016-01-11 21:35 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-01-11 21:32:56 PST
Add a build flag for custom element and enable it by default on Mac and iOS ports.
Comment 1 Ryosuke Niwa 2016-01-11 21:35:07 PST
Created attachment 268745 [details]
Adds a build flag
Comment 2 Alex Christensen 2016-01-11 23:17:51 PST
Comment on attachment 268745 [details]
Adds a build flag

View in context: https://bugs.webkit.org/attachment.cgi?id=268745&action=review

> Source/cmake/OptionsEfl.cmake:91

Why efl but no gtk?

> Source/cmake/WebKitFeatures.cmake:93

I guess it doesn't make a difference, because not mentioning it is the same as turning it off.
Comment 3 WebKit Commit Bot 2016-01-12 13:25:49 PST
Comment on attachment 268745 [details]
Adds a build flag

Clearing flags on attachment: 268745

Committed r194921: <http://trac.webkit.org/changeset/194921>
Comment 4 WebKit Commit Bot 2016-01-12 13:25:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Catanzaro 2016-01-12 21:48:50 PST
(In reply to comment #2)
> Why efl but no gtk?

I prefer not to override the default value unless we need it to be different for some GTK-specific reason, see bug #152615, or we want it to be public. Eventually it would make sense for the other ports to do this as well. So not touching OptionsGTK.cmake was correct.

It would be good to clean up the options lists for EFL and Windows and Mac as we have for GTK (and also to think about which options should be public and which private).