Bug 153005 – Add a build flag for custom element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Add a build flag for custom element and enable it by default on Mac and iOS ports.

[Ryosuke Niwa]

Created attachment 268745 [details]
Adds a build flag

[Alex Christensen]

Comment on attachment 268745 [details]
Adds a build flag

View in context: https://bugs.webkit.org/attachment.cgi?id=268745&action=review

> Source/cmake/OptionsEfl.cmake:91
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_ELEMENTS PRIVATE OFF)

Why efl but no gtk?

> Source/cmake/WebKitFeatures.cmake:93
> +    WEBKIT_OPTION_DEFINE(ENABLE_CUSTOM_ELEMENTS "Toggle custom elements support" PRIVATE OFF)

I guess it doesn't make a difference, because not mentioning it is the same as turning it off.

[WebKit Commit Bot]

Comment on attachment 268745 [details]
Adds a build flag

Clearing flags on attachment: 268745

Committed r194921: <http://trac.webkit.org/changeset/194921>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

(In reply to comment #2)
> Why efl but no gtk?

I prefer not to override the default value unless we need it to be different for some GTK-specific reason, see bug #152615, or we want it to be public. Eventually it would make sense for the other ports to do this as well. So not touching OptionsGTK.cmake was correct.

It would be good to clean up the options lists for EFL and Windows and Mac as we have for GTK (and also to think about which options should be public and which private).