Bug 152615 - [GTK][CMake] Do not override default values of build options with the default value
Summary: [GTK][CMake] Do not override default values of build options with the default...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC All
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-31 09:36 PST by Michael Catanzaro
Modified: 2015-12-31 10:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2015-12-31 09:37 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-12-31 09:36:38 PST 
Override the default value of build options only when the default value for the GTK+ port is actually different than the default value in WebKitFeatures.cmake. This way we don't accidentally override changes to default values in WebKitFeatures.cmake. We should use the values in WebKitFeatures.cmake except when we make an active choice to do otherwise.
Comment 1 Michael Catanzaro 2015-12-31 09:37:59 PST 
Created attachment 268042 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-31 10:51:03 PST 
Comment on attachment 268042 [details]
Patch

Clearing flags on attachment: 268042

Committed r194458: <http://trac.webkit.org/changeset/194458>
Comment 3 WebKit Commit Bot 2015-12-31 10:51:06 PST 
All reviewed patches have been landed.  Closing bug.