Bug 152829 - Use a pointer instead of PassRefPtr in AbstractView argument of UIEvent class
Summary: Use a pointer instead of PassRefPtr in AbstractView argument of UIEvent class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2016-01-07 01:11 PST by Gyuyoung Kim
Modified: 2016-01-12 09:24 PST (History)
7 users (show)

See Also:

Attachments
Patch (30.17 KB, patch)
2016-01-07 01:14 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (32.90 KB, patch)
2016-01-07 18:08 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.05 MB, application/zip)
2016-01-07 18:40 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (951.21 KB, application/zip)
2016-01-07 18:58 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (874.31 KB, application/zip)
2016-01-07 19:01 PST, Build Bot 		no flags Details
Patch (32.65 KB, patch)
2016-01-08 20:19 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-01-07 01:11:16 PST 
As a step to reduce uses of PassRefPtr, UIEvent class doesn't need to use PassRefPtr for AbstractView argument. Nobody hands us ownership when making one of these objects.
Comment 1 Gyuyoung Kim 2016-01-07 01:14:42 PST 
Created attachment 268446 [details]
Patch
Comment 2 Gyuyoung Kim 2016-01-07 18:08:14 PST 
Created attachment 268520 [details]
Patch
Comment 3 WebKit Commit Bot 2016-01-07 18:09:25 PST 
Attachment 268520 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:131:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2016-01-07 18:40:25 PST 
Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/664814

New failing tests:
jquery/event.html
Comment 5 Build Bot 2016-01-07 18:40:29 PST 
Created attachment 268522 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Chris Dumez 2016-01-07 18:54:12 PST 
Comment on attachment 268520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268520&action=review

> Source/WebCore/dom/UIEvent.h:85
> +    AbstractView* m_view;

You are no longer refing the view here, why is this ok?
Comment 7 Build Bot 2016-01-07 18:58:15 PST 
Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/664880

New failing tests:
jquery/event.html
Comment 8 Build Bot 2016-01-07 18:58:18 PST 
Created attachment 268523 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-01-07 19:01:39 PST 
Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/664869

New failing tests:
jquery/event.html
Comment 10 Build Bot 2016-01-07 19:01:44 PST 
Created attachment 268525 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Gyuyoung Kim 2016-01-08 20:19:49 PST 
Created attachment 268606 [details]
Patch
Comment 12 WebKit Commit Bot 2016-01-08 20:21:10 PST 
Attachment 268606 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:131:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Gyuyoung Kim 2016-01-08 21:27:24 PST 
(In reply to comment #6)
> Comment on attachment 268520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268520&action=review
> 
> > Source/WebCore/dom/UIEvent.h:85
> > +    AbstractView* m_view;
> 
> You are no longer refing the view here, why is this ok?

I did same fault. Fixed it.
Comment 14 WebKit Commit Bot 2016-01-12 09:24:06 PST 
Comment on attachment 268606 [details]
Patch

Clearing flags on attachment: 268606

Committed r194896: <http://trac.webkit.org/changeset/194896>
Comment 15 WebKit Commit Bot 2016-01-12 09:24:13 PST 
All reviewed patches have been landed.  Closing bug.