Bug 152829 – Use a pointer instead of PassRefPtr in AbstractView argument of UIEvent class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

As a step to reduce uses of PassRefPtr, UIEvent class doesn't need to use PassRefPtr for AbstractView argument. Nobody hands us ownership when making one of these objects.

[Gyuyoung Kim]

Created attachment 268446 [details]
Patch

[Gyuyoung Kim]

Created attachment 268520 [details]
Patch

[WebKit Commit Bot]

Attachment 268520 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:131:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/664814

New failing tests:
jquery/event.html

[Build Bot]

Created attachment 268522 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Chris Dumez]

Comment on attachment 268520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268520&action=review

> Source/WebCore/dom/UIEvent.h:85
> +    AbstractView* m_view;

You are no longer refing the view here, why is this ok?

[Build Bot]

Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/664880

New failing tests:
jquery/event.html

[Build Bot]

Created attachment 268523 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 268520 [details]
Patch

Attachment 268520 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/664869

New failing tests:
jquery/event.html

[Build Bot]

Created attachment 268525 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Gyuyoung Kim]

Created attachment 268606 [details]
Patch

[WebKit Commit Bot]

Attachment 268606 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:131:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

(In reply to comment #6)
> Comment on attachment 268520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268520&action=review
> 
> > Source/WebCore/dom/UIEvent.h:85
> > +    AbstractView* m_view;
> 
> You are no longer refing the view here, why is this ok?

I did same fault. Fixed it.

[WebKit Commit Bot]

Comment on attachment 268606 [details]
Patch

Clearing flags on attachment: 268606

Committed r194896: <http://trac.webkit.org/changeset/194896>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.