Bug 152583 – Intl.DateTimeFormat('en', null) should throw a TypeError

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Sukolsak Sakshuwong]

According to ECMA-402 (2nd edition), 12.1.1, passing null as |options| to InitializeDateTimeFormat should throw a TypeError exception.

http://www.ecma-international.org/ecma-402/2.0/ECMA-402.pdf

[Sukolsak Sakshuwong]

Created attachment 267981 [details]
Patch

[Andy VanWagoner]

I had noticed that and also included the same fix in my patch for Date.prototype.toLocaleString(). https://bugs.webkit.org/show_bug.cgi?id=147611

[Sukolsak Sakshuwong]

(In reply to comment #2)
> I had noticed that and also included the same fix in my patch for
> Date.prototype.toLocaleString().
> https://bugs.webkit.org/show_bug.cgi?id=147611

Oops, sorry. I didn't see it. Please feel free to close this bug.

[WebKit Commit Bot]

Comment on attachment 267981 [details]
Patch

Rejecting attachment 267981 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 267981, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
l-datetimeformat-expected.txt
Hunk #1 FAILED at 82.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/js/intl-datetimeformat-expected.txt.rej
patching file LayoutTests/js/script-tests/intl-datetimeformat.js
Hunk #1 FAILED at 162.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/js/script-tests/intl-datetimeformat.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/710243

[Sukolsak Sakshuwong]

This bug has been fixed in https://bugs.webkit.org/show_bug.cgi?id=147611