Bug 147611 – [INTL] Implement Date.prototype.toLocaleString in ECMA-402

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Andy VanWagoner]

Implement ECMA-402 2.0 13.3.1 Date.prototype.toLocaleString ([locales [, options ]])
http://ecma-international.org/publications/standards/Ecma-402.htm

This definition supersedes the definition provided in ES2015, 20.3.4.39.

[Andy VanWagoner]

Created attachment 267927 [details]
Patch

[Build Bot]

Comment on attachment 267927 [details]
Patch

Attachment 267927 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/611564

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Comment on attachment 267927 [details]
Patch

Attachment 267927 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/611556

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Created attachment 267930 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Created attachment 267931 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267927 [details]
Patch

Attachment 267927 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/611574

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Created attachment 267932 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Andy VanWagoner]

Created attachment 267933 [details]
Patch

[Build Bot]

Comment on attachment 267933 [details]
Patch

Attachment 267933 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/611958

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Created attachment 267934 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267933 [details]
Patch

Attachment 267933 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/611957

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Created attachment 267935 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267933 [details]
Patch

Attachment 267933 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/611956

New failing tests:
js/date-toLocaleString.html

[Build Bot]

Created attachment 267936 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Andy VanWagoner]

Created attachment 267937 [details]
Patch

[Andy VanWagoner]

Comment on attachment 267937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267937&action=review

> Source/JavaScriptCore/runtime/DatePrototype.cpp:496
> +#endif // ENABLE(INTL)

I need to handle the unused param in the else case

[Andy VanWagoner]

Created attachment 269027 [details]
Patch

[Benjamin Poulain]

Comment on attachment 269027 [details]
Patch

LGTM, let's land.

[WebKit Commit Bot]

Comment on attachment 269027 [details]
Patch

Clearing flags on attachment: 269027

Committed r195138: <http://trac.webkit.org/changeset/195138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.