Bug 152460 – [WK2][EFL] Use WebsiteDataStore instead of WebDatabaseManager which has been deleted in r194295

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Joonghun Park]

Use WebsiteDataStore to support EFL WebDatabase API and to fix build break.

[Joonghun Park]

Created attachment 267685 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 267685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267685&action=review

> Source/WebKit2/ChangeLog:3
> +        [WK2][EFL] Fix Build break since r194295

I think this bug title is too meaningless. This patch implements new feature for EFL port. Please re-write bug title with more proper one.

> Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:2
> + * Copyright (C) 2011 Samsung Electronics

2011 ?

> Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:77
> +    return String::fromUTF8(g_get_user_cache_dir()) + directoryName;

If possible, I want to avoid to use glib functions though we have used it to support some features.

> Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:82
> +    return String::fromUTF8(g_get_user_data_dir()) + directoryName;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h:40
> +    explicit EwkDatabaseManager();

No need to keep *explicit*.

[Joonghun Park]

Created attachment 267729 [details]
Patch

[Joonghun Park]

(In reply to comment #2)
> Comment on attachment 267685 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267685&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [WK2][EFL] Fix Build break since r194295
> 
> I think this bug title is too meaningless. This patch implements new feature
> for EFL port. Please re-write bug title with more proper one.
> 
> > Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:2
> > + * Copyright (C) 2011 Samsung Electronics
> 
> 2011 ?
> 
> > Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:77
> > +    return String::fromUTF8(g_get_user_cache_dir()) + directoryName;
> 
> If possible, I want to avoid to use glib functions though we have used it to
> support some features.
> 
> > Source/WebKit2/UIProcess/API/efl/APIWebsiteDataStoreEfl.cpp:82
> > +    return String::fromUTF8(g_get_user_data_dir()) + directoryName;
> 
> ditto.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_database_manager_private.h:40
> > +    explicit EwkDatabaseManager();
> 
> No need to keep *explicit*.

Gyuyoung, I handled all the comments you left in previous patch.
Please take a look this again

[WebKit Commit Bot]

Comment on attachment 267729 [details]
Patch

Clearing flags on attachment: 267729

Committed r194325: <http://trac.webkit.org/changeset/194325>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.